CI: split lint into separate job (run once instead of 18× per-matrix-cell)#660
Open
ryan-williams wants to merge 1 commit intotreeverse:mainfrom
Open
CI: split lint into separate job (run once instead of 18× per-matrix-cell)#660ryan-williams wants to merge 1 commit intotreeverse:mainfrom
ryan-williams wants to merge 1 commit intotreeverse:mainfrom
Conversation
The previous workflow ran `nox -s lint` inside every test matrix cell (3 OS × 6 Python versions = 18 runs of the same lint). This change: - Extracts lint into its own fast job (ubuntu-latest, Python 3.12) - Makes `tests` depend on lint (no point running 18 expensive test cells if lint is broken) - Preserves `fail-fast: false` on the test matrix so platform-specific failures remain visible
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #660 +/- ##
==========================================
+ Coverage 72.42% 73.82% +1.40%
==========================================
Files 67 65 -2
Lines 5132 5357 +225
Branches 605 622 +17
==========================================
+ Hits 3717 3955 +238
+ Misses 1227 1209 -18
- Partials 188 193 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Extract
nox -s lintfrom the test matrix into its own dedicated job.Why
The current workflow runs
nox -s lintinside every test matrix cell: 3 OS × 6 Python versions = 18 redundant lint runs per CI trigger. Lint is platform- and Python-version-independent, so it only needs to run once.Change
lintjob: ubuntu-latest, Python 3.12, runs oncetestsjob nowneeds: [lint]— no point running 18 expensive test cells if lint is brokencheckjob updated toneeds: [lint, tests]fail-fast: falsepreserved on the test matrix — platform-specific failures (e.g. Windows-only) remain fully visibleNo test logic changes; just moving
nox -s lint+ its pre-commit cache out of the matrix.