This repository was archived by the owner on Nov 26, 2024. It is now read-only.
The game use SFML minimally#71
Open
richelbilderbeek wants to merge 8 commits into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #71 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 104 102 -2
Branches 1 1
=========================================
- Hits 104 102 -2 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #70
About the
gcovthings:game.prois modified to allow (1) all team members to work, and (2) allow GitHub Action to actually measure the code coverage.About
LOGIC_ONLY: this defineLOGIC_ONLYdetermines if the game is run visually. On GitHub Action, showing a window will crash the program (as there is no screen to display it on).We did not fix the lint :-)
If anything is unclear, or you are just wondering, hit me and Theo with your questions and feedback :-)