Skip to content

fix(grafana): correct stale instant-tier claim in EIP-1559 max-fee panel#1596

Open
pragmaxim wants to merge 1 commit into
masterfrom
enhancement/grafana-dashboard-fee-panel
Open

fix(grafana): correct stale instant-tier claim in EIP-1559 max-fee panel#1596
pragmaxim wants to merge 1 commit into
masterfrom
enhancement/grafana-dashboard-fee-panel

Conversation

@pragmaxim

@pragmaxim pragmaxim commented Jul 1, 2026

Copy link
Copy Markdown
Contributor
  • Reviewed the recent Grafana/fee-related commits for the suspected mixing of "Fiat Rates" and "Fees" concepts — confirmed they are cleanly separated (distinct panel keys, metric prefixes, and Go structs), no changes needed there.
  • Found and fixed a real, unrelated staleness bug: a2ec3b3d remapped 1inch's fee tiers (medium→low, high→medium, instant→high), so 1inch no longer exposes a separate instant tier. The fees.eip1559_max_fee panel description still claimed 1inch was a "provider that returns four tiers", which is no longer true and would send an on-call engineer chasing a phantom instant-tier discrepancy.

a2ec3b3 remapped 1inch's four fee tiers onto low/medium/high (discarding the
low tier and folding instant into high), so 1inch no longer surfaces a
separate instant tier. The panel description still claimed 1inch was a
"provider that return[s] four tiers", which is no longer true and would send
an on-call engineer chasing a phantom instant-tier discrepancy.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@pragmaxim pragmaxim requested a review from cranycrane July 6, 2026 09:56

@cranycrane cranycrane left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants