Skip to content

fix(eth): avoid int64 overflow in on-chain base fee conversion #1605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pragmaxim merged 1 commit into from
Jul 7, 2026
Merged

fix(eth): avoid int64 overflow in on-chain base fee conversion #1605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion bchain/coins/eth/ethrpc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2004,7 +2004,10 @@ func (b *EthereumRPC) EthereumTypeGetEip1559Fees() (*bchain.Eip1559Fees, error)

hs, _ := json.Marshal(h)
baseFee, _ := hexutil.DecodeUint64(h.BaseFeePerGas[blocks-1])
fees.BaseFeePerGas = big.NewInt(int64(baseFee))
// SetUint64, not big.NewInt(int64(...)): base fee is wei and a value above math.MaxInt64
// (~9.22e18) would wrap negative on the int64 cast. Unreachable on mainnet today but possible
// on high-fee L2s. Matches the header path in attachBlockGas.
fees.BaseFeePerGas = new(big.Int).SetUint64(baseFee)
// We expose only baseFeePerGas here and deliberately do NOT add a separate "next block" base-fee
// field. eth_feeHistory returns one extra projected element beyond the requested range, but its
// meaning is backend-dependent: nodes with no distinct pending block (e.g. Erigon, which ethereum
Expand Down
Loading