This repository was archived by the owner on Mar 13, 2026. It is now read-only.
Standardize database queries and improve error handling in data source modules#440
Open
RinZ27 wants to merge 1 commit intotruefoundry:mainfrom
Open
Standardize database queries and improve error handling in data source modules#440RinZ27 wants to merge 1 commit intotruefoundry:mainfrom
RinZ27 wants to merge 1 commit intotruefoundry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current implementation of the SingleStore vector database module uses direct string formatting for SQL queries. Transitioning to parameterized queries in
list_data_point_vectorsanddelete_data_point_vectorsensures better handling of input data and prevents potential query structure corruption. This update replaces all manual formatting with the standard placeholder syntax (%s) for better consistency across the codebase.Refining the data source router in
backend/server/routers/data_source.pywas also necessary to improve how exceptions are reported to the client. Detailed error traces from the backend are now logged to the server, while the client receives a standardized response for invalid URIs or connection failures.Some minor cleanup was performed in the affected blocks to remove unused variables and align with the project's linting standards.