Skip to content

fix(sdjwt): add "~" to serialized SDJWTs without keybinding#100

Open
romano21A wants to merge 1 commit intotrustbloc:mainfrom
romano21A:fix/sdjwt-missing-tilde
Open

fix(sdjwt): add "~" to serialized SDJWTs without keybinding#100
romano21A wants to merge 1 commit intotrustbloc:mainfrom
romano21A:fix/sdjwt-missing-tilde

Conversation

@romano21A
Copy link
Copy Markdown

Fixes #99.

It may break code which has added the ~ manually till now. I ran all the tests under sdjwt and updated them if necessary.

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 10, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

Signed-off-by: Roman <mail.romano21A@gmail.com>
@romano21A romano21A force-pushed the fix/sdjwt-missing-tilde branch from d87dd3f to 0b009c3 Compare June 10, 2025 09:59
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Jun 10, 2025

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to some user(s) on file. Please see the contribution guidelines to sign the CLA.

@romano21A romano21A closed this Jun 17, 2025
@romano21A
Copy link
Copy Markdown
Author

Sorry for closing and reopening, I had just found the old version of the spec where the combined format for issuance did indeed not have a tilde at the end and thought my issue/pull request was wrong.
But I just double-checked and the current draft does indeed have that last tilde in the issuance example

@romano21A romano21A reopened this Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serialized SD-JWTs without keybinding do not match spec

1 participant