Add ccw rotation to pcb note text#531
Open
rushabhcodes wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds optional counter-clockwise rotation support to PcbNoteText so PCB note text can be rotated consistently with other PCB text/shape elements.
Changes:
- Extend
PcbNoteTextZod schema + exported TypeScript interface with optionalccw_rotation. - Add a focused parsing test for
ccw_rotationonpcb_note_text. - Update generated docs (
README.md,docs/PCB_COMPONENT_OVERVIEW.md) to include the new field.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/pcb_note_components.test.ts | Adds test coverage to ensure ccw_rotation is accepted and parsed for note text. |
| src/pcb/pcb_note_text.ts | Introduces the optional ccw_rotation field to the schema and interface. |
| README.md | Updates published interface docs to include ccw_rotation. |
| docs/PCB_COMPONENT_OVERVIEW.md | Updates generated component overview docs to include ccw_rotation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seveibar
reviewed
Apr 11, 2026
Contributor
seveibar
left a comment
There was a problem hiding this comment.
what's the motivation for this feature? It's not a bad idea for a feature, but it's not very important unless it's connected to an actual user issue
Contributor
Author
|
PcbNoteText was missing the optional rotation field that related PCB text shapes already support, which made note text inconsistent with the rest of the PCB text surface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ccw_rotationsupport toPcbNoteTextin the zod schema and exported TypeScript interfaceWhy
PcbNoteTextwas missing the optional rotation field that related PCB text shapes already support, which made note text inconsistent with the rest of the PCB text surface.Impact
Users can now provide
ccw_rotationonpcb_note_textelements without type or schema mismatches.Validation
bun test tests/pcb_note_components.test.tsnpm run build