fix: respect schematic trace auto-label opt-out#2341
Open
ItsOtherMauridian wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2243.
schTraceAutoLabelEnabled={false}is typechecked but the grouped schematic trace render path still inserted automatic schematic net labels. This made the prop ineffective for named-net connections rendered through the MSP schematic trace routing flow.This PR gates the automatic net-label insertion paths in
Group_doInitialSchematicTraceRenderbehindschTraceAutoLabelEnabled !== falsewhile keeping trace rendering itself unchanged.Test plan
npx bun test tests/repros/repro2243-sch-trace-auto-label-disabled.test.tsxnpx bun test tests/repros/repro13-schematic-trace-hop.test.tsx tests/repros/repro14-double-schematic-traces.test.tsx tests/components/normal-components/pcb-component-relative-positioning1.test.tsx tests/components/tracenpx tsc --noEmit