fix: avoid extra traces for label-only nets#427
Open
jarnodevries-byte wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jarnodevries-byte
force-pushed
the
bounty/issue-79-extra-net-label
branch
from
5baa6a1 to
ab6d90a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #79.\n\n## Summary\n- skip route generation for nets that can be fully represented with net labels\n- keep direct connections routable even when the net name also has labels\n- add repro79/repro61 regression coverage\n- update affected solver snapshots\n\n## Tests\n-
bun test tests/solvers/MspConnectionPairSolver/MspConnectionPairSolver_repro79.test.ts tests/solvers/SchematicTracePipelineSolver/SchematicTracePipelineSolver_repro61.test.ts tests/solvers/MspConnectionPairSolver/MspConnectionPairSolver_repro1.test.ts\n-bun test\n-bunx tsc --noEmit\n-git diff --check