feat: SchematicDebugObjectsSolver - debug visualization of trace endpoints, junctions and label anchors#435
Open
wbobbynmworley wants to merge 7 commits into
Conversation
…e endpoints, junctions, and label anchors - New solver generates debug circles/texts for trace endpoints, direction-change junctions, and net label anchors - 6 unit tests covering: endpoints, junctions, label anchors, empty traces, straight lines, and getOutput - Integrated into pipeline after netLabelTraceCollisionSolver - Relates to tscircuit#78
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…Id with globalConnNetId
- Add import { describe, test, expect } from 'bun:test' to test file
- Replace trace.netId references with trace.globalConnNetId ?? trace.mspPairId
- Remove netId from SolvedTracePath mock (not a valid property)
- Add mspConnectionPairIds to mock trace data
- Circle: {center: {x,y}, radius} instead of {x, y, r}
- Rect: use 'stroke' instead of 'strokeColor'
- Remove 'as any' casts that were masking type errors
- Changed circle objects from {x, y, r} to {center: {x, y}, radius}
- Updated SVG snapshots to reflect new debug objects output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements SchematicDebugObjectsSolver for issue #78 ($75 bounty).
What it does
Generates debug circles and text labels for:
Implementation
SchematicDebugObjectsSolverSchematicTracePipelineSolveras the final step afternetLabelTraceCollisionSolverTest plan
Closes #78