Draft
Conversation
|
All Mac Developers automatically get Metal Shader Converter through XCode most likely, which includes a dxc dylib and executable. on Mac would it have to be gated by Wicked's versioning or by Metal Shader Converters? |
Collaborator
Author
|
I think we should use the same DXC version for everything. DXC changes details between versions and it sometimes has bugs (like eg. this version creates incorrect SPIR-V code). Ignoring the different APIs for now, it would make debugging between platforms more difficult since you have to take the different behaviour of the DXC versions into account. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@turanszkij As mentioned in Discord, this version seems to create invalid SPIR-V for some shaders.
Also, since I don't have a Mac, the dylib is missing, but homebrew might have the current version. Alternatively, the github repo should compile on MacOS