Skip to content

azurestore: Fix InvalidHeaderValue error due to empty sentinel block#1379

Merged
Acconut merged 1 commit into
tus:mainfrom
DotaPie:azurestore-fix-1358
Jun 16, 2026
Merged

azurestore: Fix InvalidHeaderValue error due to empty sentinel block#1379
Acconut merged 1 commit into
tus:mainfrom
DotaPie:azurestore-fix-1358

Conversation

@DotaPie

@DotaPie DotaPie commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Need this fix for my deployment of TUSD in production. This should fix #1358.

@DotaPie

DotaPie commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Re-pushed commit (added GPG verification)

@DotaPie DotaPie force-pushed the azurestore-fix-1358 branch from d8117d8 to a3a68f2 Compare June 13, 2026 00:00
@Acconut

Acconut commented Jun 13, 2026

Copy link
Copy Markdown
Member

Thank you for submitting a fix! Can you describe what you've done and how it addresses the problem?

@DotaPie

DotaPie commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

Problem: empty sentinel block staged in NewUpload (to fix #1286) is length = 0, and azure rejects zero-length StageBlock with InvalidHeaderValue (#1358), so NewUpload fails

Downgrading to v2.9.0 was first workaround for our problem. This PR (forked from latest main) stages the sentinel as a 1-byte block under a reserved ID instead, keeping #1349's fix intact.

We built and deployed it (ghcr.io/dotapie/tusd:fix-1358) to our AKS cluster and redirecting uploads to azure blob storage now works just fine.

Edit 1: It was passing E2E test, because it is using azurite, which accepts zero-length StageBlock

@Acconut Acconut changed the title azurestore fix azurestore: Fix InvalidHeaderValue error due to empty sentinel block Jun 16, 2026

@Acconut Acconut left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this issue!

@Acconut Acconut merged commit a4296d4 into tus:main Jun 16, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

azurestore: InvalidHeaderValue during upload in v2.9.1+

2 participants