azurestore: Fix InvalidHeaderValue error due to empty sentinel block#1379
Conversation
|
Re-pushed commit (added GPG verification) |
d8117d8 to
a3a68f2
Compare
|
Thank you for submitting a fix! Can you describe what you've done and how it addresses the problem? |
|
Problem: empty sentinel block staged in NewUpload (to fix #1286) is length = 0, and azure rejects zero-length StageBlock with InvalidHeaderValue (#1358), so NewUpload fails Downgrading to v2.9.0 was first workaround for our problem. This PR (forked from latest main) stages the sentinel as a 1-byte block under a reserved ID instead, keeping #1349's fix intact. We built and deployed it (ghcr.io/dotapie/tusd:fix-1358) to our AKS cluster and redirecting uploads to azure blob storage now works just fine. Edit 1: It was passing E2E test, because it is using azurite, which accepts zero-length StageBlock |
Acconut
left a comment
There was a problem hiding this comment.
Thank you for fixing this issue!
Need this fix for my deployment of TUSD in production. This should fix #1358.