Skip to content

Rename overrideSettings to just settings #83

Description

@slifty

Task

Description

IAppliance has a documented constructor parameter of overrideSettings

As @chriszs points out in this PR, really those are just settngs, what is override doing there?

Unless someone can articulate a good reason for calling it overrideSettings, lets change it to settings.

Note: this doesn't actually impact the API, so this would be a patch level fix.

Relevant Resources / Research

None.

Related Issues

None.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions