Skip to content

bitwise-and BitwiseAnd for Int and Word#419

Open
yaitskov wants to merge 1 commit into
tweag:masterfrom
yaitskov:bitwise-and
Open

bitwise-and BitwiseAnd for Int and Word#419
yaitskov wants to merge 1 commit into
tweag:masterfrom
yaitskov:bitwise-and

Conversation

@yaitskov
Copy link
Copy Markdown

No description provided.

@aspiwack
Copy link
Copy Markdown
Member

Hello,

Thanks for your PR. Can you elaborate on your design? Why create a BitwiseAnd class, in particular?

@yaitskov
Copy link
Copy Markdown
Author

yaitskov commented May 25, 2022

Thanks for your PR. Can you elaborate on your design? Why create a BitwiseAnd class, in particular?

I was trying to mimic linear-base approach on tackling Num class i.e. a class per method.
Data.Bits class is pretty populated with methods too.
I haven't defined Bits in PR just because not sure about getting review responses so saved on initial efforts ;).

I don't have strong opinion about particular class name and open to alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants