Skip to content

Issue #254: support exclamation point as ending char in path#255

Open
tparsioan wants to merge 2 commits into
twitter:masterfrom
tparsioan:patch-1
Open

Issue #254: support exclamation point as ending char in path#255
tparsioan wants to merge 2 commits into
twitter:masterfrom
tparsioan:patch-1

Conversation

@tparsioan

@tparsioan tparsioan commented Feb 22, 2018

Copy link
Copy Markdown

This addresses the issue in 'extractUrlsWithIndices' function where it does not properly recognize the full URL if the ending character in the path is an exclamation point (!). With a URL as such:
https://www.domain.com/locale/#!?key1=value1&key2=value2

The complete URL 'https://www.domain.com/locale/#!?key1=value1&key2=value2' will be recognized as a URL instead of just the part preceding the exclamation point 'https://www.domain.com/locale/#'.

@CLAassistant

CLAassistant commented Feb 22, 2018

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ tparsioan
❌ taufik-parsioan
You have signed the CLA already but the status is still pending? Let us recheck it.

@tparsioan

Copy link
Copy Markdown
Author

@rcastera

@rcastera

Copy link
Copy Markdown
Contributor

@kaushlakers can you take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants