Add volume controls for crying and hunger sounds#304
Open
Defalt36 wants to merge 1 commit into
Open
Conversation
b09791c to
d0c9848
Compare
Contributor
|
Can you elaborate a little on why these 2 sounds? You can argue the hunger sound is a special sound, outside of other sounds used by objects and animations. But crying sound is the latter. I can imagine people asking the same for the chime (also special sound), horse-carts, bicycles etc. |
Contributor
Author
It's because they are two very loud and annoying sounds. I don't think any other sound control is needed to be put there because:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And Jason wept.