Tpi 285 upgrade react#60
Open
JaimeS98 wants to merge 9 commits into
Open
Conversation
… code and swift code
…use node 24 and setup correct version of ruby
sanj-tyro
reviewed
Jul 13, 2026
sanj-tyro
reviewed
Jul 13, 2026
sanj-tyro
reviewed
Jul 14, 2026
sanj-tyro
reviewed
Jul 14, 2026
| @@ -0,0 +1,5 @@ | |||
| // Global JSX namespace shim for @types/react@19 compatibility. | |||
| // React 19 moved JSX to React.JSX; this restores the global JSX.Element alias. | |||
| declare namespace JSX { | |||
There was a problem hiding this comment.
If we're setting up JSX as a global alias, is the import in some other specific files in this PR necessary?
Contributor
Author
There was a problem hiding this comment.
Will look if they other imports are unnecessary now, cheers
sanj-tyro
reviewed
Jul 14, 2026
sanj-tyro
reviewed
Jul 14, 2026
sanj-tyro
reviewed
Jul 14, 2026
cmanchanda
reviewed
Jul 14, 2026
cmanchanda
reviewed
Jul 14, 2026
cmanchanda
reviewed
Jul 14, 2026
cmanchanda
reviewed
Jul 14, 2026
sanj-tyro
reviewed
Jul 14, 2026
fix: populate Gemfile.lock checksums after cocoapods upgrade update readme and e2e script to better select device update tests, and dependencies plus ci fix for ios update gemfile lock to point away from vulnerable activesupport versions and update ios-unit ci update to macoc-15 for unit create simulator for ios ci tests update podfile min target and build.gradle to not fail on emtpy tests remove duplicate ios simulators fix native unit tests update e2e tests make sure to install ios simulator update e2e github action to try and optimise the flow add concurrency cancel in progress to unit and dependency fix prepack order in android e2e added property check and restored challenge test to android fix gradle
JaimeS98
force-pushed
the
tpi-285-upgrade-react
branch
from
July 21, 2026 01:22
f1916b0 to
c513585
Compare
sanj-tyro
reviewed
Jul 23, 2026
| @@ -0,0 +1,4 @@ | |||
| export enum Colors { | |||
There was a problem hiding this comment.
can we import the other one created? or not possible?
Contributor
Author
There was a problem hiding this comment.
yeah can probably just have one actually.
sanj-tyro
reviewed
Jul 23, 2026
| {paths: [process.argv[1]]}, | ||
| )', __dir__]).strip | ||
|
|
||
| MIN_IOS_VERSION='16.0' |
There was a problem hiding this comment.
would've preferred to refer to this variable (wherever it is) and set that in one spot vs hard-coding here.
If we need to bump it up in the future, might be hard to know to do it here too
Contributor
Author
There was a problem hiding this comment.
centralised it on package.json
…and fixing some types in tests podfile.lock update fix import for min ios version for example podfile
JaimeS98
force-pushed
the
tpi-285-upgrade-react
branch
from
July 24, 2026 00:29
e158dff to
05e5aed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR
Upgrade SDK to be compatible with RN v0.86.0 <-> RNv0.78.0
Upgrade Example app to be using RN v0.86.0 as our main target
Testing
Android
iOS