Skip to content

Header-only coordijk.h v2 #1154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajfriend merged 3 commits into from
Apr 22, 2026
Merged

Header-only coordijk.h v2 #1154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
23df299
move to coordijk.h
ajfriend Apr 17, 2026
8829608
update cmake
ajfriend Apr 17, 2026
4cb98bf
FaceIJK lastFijk = {0};
ajfriend Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ set(LIB_SOURCE_FILES
src/h3lib/include/cellsToMultiPoly.h
src/h3lib/lib/h3Assert.c
src/h3lib/lib/algos.c
src/h3lib/lib/coordijk.c
src/h3lib/lib/bbox.c
src/h3lib/lib/polygon.c
src/h3lib/lib/polyfill.c
Expand Down Expand Up @@ -510,6 +509,9 @@ macro(add_h3_executable name)
)
target_compile_options(${name} PRIVATE ${H3_COMPILE_FLAGS})
target_link_libraries(${name} PRIVATE ${H3_LINK_FLAGS})
if(ENABLE_COVERAGE)
target_compile_definitions(${name} PRIVATE H3_COVERAGE_TEST=1)
endif()
Comment on lines +512 to +514
Copy link
Copy Markdown
Collaborator

@isaacbrodsky isaacbrodsky Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because some of the test executables call coordijk.h code directly?

Copy link
Copy Markdown
Collaborator Author

@ajfriend ajfriend Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's called from these:

  • testCoordIjkInternal.c
  • fuzzerInternalCoordIjk.c

endif()
endmacro()

Expand Down
Loading
Loading