Integrate Gosper iterator into cellsToMultiPolygon#1168
Closed
ajfriend wants to merge 24 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the code I was using to test out incorporating the Gosper Iterator from #1138 into the
cells_to_polygonalgorithm, which should provide a significant speedup for compacted cell sets.I'm leaving this here for future reference for someone to take over from here.
What we still need to think through is how this will be reflected in the API. We only get speed benefits on compacted sets. Do we take flat sets and compact them under the hood automatically? Do we have different functions that expect flat vs compacted inputs? What validation do we do, and how do we handle duplicate cells or descendants of cells being present?