fix: remove hard-coded colors from Mermaid diagrams for dark mode readability - #702
fix: remove hard-coded colors from Mermaid diagrams for dark mode readability#702rkratky wants to merge 2 commits into
Conversation
|
Note for reviewers: This PR does not change any content -- it only improves styling and formatting of diagrams. No text, incl. in the diagrams has been touched. |
cpaelzer
left a comment
There was a problem hiding this comment.
+1 for the changes to the MIR pages, checked the rendering on https://canonical-ubuntu-projectubuntu--702.com.readthedocs.build/MIR/mir-process-states/ and it is fine.
setharnold
left a comment
There was a problem hiding this comment.
Is ISSUES-ASSESSMENT.md supposed to be part of this? it feels like it's intended for your own local use.
Yeah, that's an oversight, of course. Thanks. Fixed now. |
|
@rkratky also giving my ok for the DMB (in addition to the MIR which I did earlier) |
Description
fill,stroke,background,classDef,style) from all Mermaid diagrams so they use the default theme, which adapts to both light and dark modesthemeVariables(fontSize,fontFamily) to each diagram to maintain consistent typography without hard-coding colorscustom_styles.cssfrom 70% to 100%Related issue
Checklist