Open
Conversation
Split out from VPR-104-accessibility-audit-CTS. Rework AssessmentBubble into a button/span pair with proper roles and labels, restyle the rating bubbles as filled chips, and rebuild the MyAssessments layout with an h1/h2 hierarchy, accessible expand/collapse controls, and a level-chip dialog. Adds test coverage for AssessmentBubble.
rlorenzo
force-pushed
the
VPR-104-accessibility-audit-CTS-myassessments
branch
from
9db50f7 to
daef548
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #155 +/- ##
=======================================
Coverage 43.24% 43.25%
=======================================
Files 862 863 +1
Lines 50405 50416 +11
Branches 4706 4711 +5
=======================================
+ Hits 21796 21805 +9
- Misses 28086 28087 +1
- Partials 523 524 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 4.85kB (0.23%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: viper-frontend-esmAssets Changed:
Files in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Accessibility improvements scoped to the CTS MyAssessments page and the shared
AssessmentBubblecomponent. Split out from #137 so the page rework and bubble redesign can land as their own PR.MyAssessments page
<h1>and the "Entrustable Professional Activities" heading to<h2>(1.3.1 Info and Relationships)aria-label+aria-expandedon the global expand-all button and each per-EPA expand button; label adapts with state ("Expand details for…" / "Collapse details for…") (4.1.2 Name, Role, Value)aria-label="Close dialog"close icon added to the "Assessment Details" dialog header (2.1.1 Keyboard)AssessmentBubblecomponent<button>elements with a stepped UC Davis blue palette (rgba(62,127,238,0.3)→rgba(11,3,139,1)), a 1.5rem diameter for a larger touch/click target, a goldfocus-visiblering, and 0.25rem horizontal spacing so adjacent bubbles never touch. Replaces the old low-contrast light blue fill (1.4.1 Use of Color, 1.4.11 Non-text Contrast)Test Coverage
AssessmentBubbleunit tests — newassessment-bubble.test.tslocks in the privacy contract (aria-label must never contain the numeric rating), the value → class mapping, click emission with the correct id, and the non-interactive span variant whenidis omitted. 15 tests covering the full component surface.Test plan
/CTS/MyAssessmentsrenders with h1 title, h2 EPA section, and keyboard-accessible expand/collapse controlsAssessmentBubblestill renders correctly in other CTS pages that use it (AssessmentEpa,AssessmentEpaEdit,AssessmentCompetency,ManageSessionCompetencies)npm run test—assessment-bubble.test.tspasses