Skip to content

Code analysis tooling + security tightening + dedupe pass #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rlorenzo wants to merge 37 commits into from

fix(quality): discard unused entry param in cache lambda

2a2229d
Select commit
Loading
Failed to load commit list.
Closed

Code analysis tooling + security tightening + dedupe pass #162

fix(quality): discard unused entry param in cache lambda
2a2229d
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded May 5, 2026 in 3s

65 new alerts

New alerts in code changed by this pull request

  • 20 warnings
  • 45 notes

Alerts not introduced by this pull request might have been detected because the code changes were too large.

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 510 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Constant condition Warning

Condition is always not null because of
call to method IsNullOrWhiteSpace
Loading
.

Check warning on line 515 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Constant condition Warning

Condition is always not null because of
call to method IsNullOrWhiteSpace
Loading
.
Condition is always not null because of
call to method IsNullOrWhiteSpace
Loading
.

Check warning on line 516 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Constant condition Warning

Condition is always not null because of
call to method IsNullOrWhiteSpace
Loading
.
Condition is always not null because of
call to method IsNullOrWhiteSpace
Loading
.

Check warning on line 521 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Constant condition Warning

Condition is always not null because of
call to method IsNullOrWhiteSpace
Loading
.
Condition is always not null because of
call to method IsNullOrWhiteSpace
Loading
.

Check warning on line 140 in web/Areas/RAPS/Services/RAPSAuditService.cs

See this annotation in the file changed.

Code scanning / CodeQL

Constant condition Warning

Condition is always null because of
... != ...
Loading
.

Check warning on line 140 in web/Areas/RAPS/Services/RAPSAuditService.cs

See this annotation in the file changed.

Code scanning / CodeQL

Constant condition Warning

Condition is always false because of
... != ...
Loading
.

Check warning on line 323 in web/Controllers/HomeController.cs

See this annotation in the file changed.

Code scanning / CodeQL

Constant condition Warning

Condition is always not null because of
call to method IsNullOrEmpty
Loading
.

Check warning on line 49 in web/Classes/Utilities/F5HttpRequest.cs

See this annotation in the file changed.

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'HttpRequestMessage' is created but not disposed.

Check warning on line 450 in test/Students/EmergencyContactControllerTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 239 in test/Students/EmergencyContactControllerTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 230 in test/ClinicalScheduler/ClinicalSchedulerTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 242 in test/ClinicalScheduler/ClinicalSchedulerTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 134 in test/ClinicalScheduler/IntegrationTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 242 in test/ClinicalScheduler/IntegrationTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 344 in test/Effort/EffortIntegrationTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 354 in test/Effort/EffortIntegrationTestBase.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 182 in test/RAPS/RolesTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
TblRole
Loading
- the conversion can be done implicitly.

Check warning on line 125 in test/Services/EmailServiceTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 211 in test/Services/EmailServiceTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check warning on line 64 in test/Students/EmergencyContactControllerTests.cs

See this annotation in the file changed.

Code scanning / CodeQL

Useless upcast Warning test

There is no need to upcast from
null
Loading
to
AaudUser
Loading
- the conversion can be done implicitly.

Check notice on line 404 in web/Classes/Utilities/IamApi.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 41 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments.

Check notice on line 85 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 418 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Generic catch clause Note

Generic catch clause.

Check notice on line 449 in web/Program.cs

See this annotation in the file changed.

Code scanning / CodeQL

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments Note

Call to 'System.IO.Path.Combine' may silently drop its earlier arguments.