Migrate framework to Eclipse E4.39 and update other dependencies#778
Migrate framework to Eclipse E4.39 and update other dependencies#778schuessf wants to merge 8 commits into
Conversation
danieldietsch
left a comment
There was a problem hiding this comment.
Wrt. to benchexec just using any launcher: I think that is ok, but I would not take the highest launcher if it finds multiple ones, but rather crash. It might be that someone copied a newer Ultimate over an older one, and by some miracle it launches. I would prefer then that the wrapper script crashes and tells us that there are multiple launchers.
|
|
||
| <requires> | ||
| <import feature="BA_FeatureDependenciesCommon"/> | ||
| <import feature="BA_FeatureUltimateCommon"/> |
There was a problem hiding this comment.
Why all these changes to the feature dependencies (also in other features)?
There was a problem hiding this comment.
@bahnwaerter changed this in b5bba47, but I don't quite remember why 😉
Sure, I changed it like that (ultimate-pa/benchexec@43634d7).
Currently, the wrapper script simply runs the specified version of |
This change also removes duplicate imports of required feature definitions.
1adc081 to
a0352e1
Compare
|
For reference, I just opened a benchexec PR already: sosy-lab/benchexec#1263 |
#757 previously updated the Eclipse dependencies to E4.37 and consolidated the target files. Building on that work, this update updates the Eclipse dependencies further to E4.39.
To achieve this, several unused feature groups (including some that no longer exist) have been removed from the target file, and the
feature.xmlfiles were cleaned up as well. Both changes should simplify future dependency updates.Additionally, the Maven plugins, covering both the build process and regular dependencies, have been updated.
Note: This PR updates the version number of
org.eclipse.equinox.launcherin several files within the Ultimate repo (e.g.,Ultimate.py). However, the tool info module in benchexec still needs to be updated, as it also depends on the exact version number (see here), which was also forgotten for the changes in #757. To avoid having to make such changes for every future dependency update, I already implemented a wildcard-based solution: ultimate-pa/benchexec@88b9aa5. If you agree with that approach, I can also open a PR for benchexec.