parse_config: add timeout to file --mime-encoding subprocess call#2318
Open
nadzyah wants to merge 1 commit intoultrabug:masterfrom
Open
parse_config: add timeout to file --mime-encoding subprocess call#2318nadzyah wants to merge 1 commit intoultrabug:masterfrom
nadzyah wants to merge 1 commit intoultrabug:masterfrom
Conversation
On some architectures (e.g. s390x) the file command can hang when its magic database is slow to load. Add timeout=3 to check_output() and handle TimeoutExpired like CalledProcessError, falling back to utf-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_config.pycallsfile --mime-encodingwith no timeout. On some architectures (like s390x), this can hang when the magic database is slow to load, blocking py3status startup indefinitely.The fix adds
timeout=3tocheck_output()and handlesTimeoutExpiredthe same way asCalledProcessError(fall back to utf-8).I've initially discovered this issue while trying to fix failing tests for the
py3statusstatus package in Ubuntu and Debian