Release 0.3.0 + 0.3.1 (validated via ICA full-pipeline runs) - #35
Merged
Conversation
…11) * add params input for sigrap tools
* update "HIGH_INF_POS" to "HIGH_I_I_POS" in VCF header for latest pcgr version * update constant for pcgr 2.2.5
* change sage vcf header to match 2024 version * move check function * add check in rescue for sage vcf * change for consistencency with pcgr
…arallelisation because OOM hypermutated samples
…'t use more core and so more memory
…e_command. Fixes #26 - Commands now fail immediately instead of continuing silently
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….2.5 tabix check)
# Conflicts: # .bumpversion.cfg # docker/Dockerfile.gpgr # pyproject.toml
This was referenced Jul 17, 2026
Merged
Closed
scwatts
approved these changes
Jul 21, 2026
scwatts
left a comment
Member
There was a problem hiding this comment.
Nice work, read over the code briefly and made a couple of minor comments, trust you've tested well :)
| ## Variation selection (annotation) ## | ||
| ###################################### | ||
| MAX_SOMATIC_VARIANTS = 500_000 | ||
| MAX_SOMATIC_VARIANTS = 450_000 |
Member
There was a problem hiding this comment.
Do we have a Slack thread (or similar) to link to for this change?
Collaborator
Author
There was a problem hiding this comment.
I believe this was an oral discussion, since PCGR's hard cap is 500k, we set 450k to avoid being right on the limit and allow margin for edge cases.
Collaborator
Author
There was a problem hiding this comment.
I updated ADR document for sash and bolt explaining rational
run_somatic_chunk -> merging_pcgr_files unconditionally called util.merge_vcf_files, which shells out to `bcftools merge`. That command requires 2+ inputs, so a sample whose variants fit in a single chunk (no splitting needed) produced a bcftools merge Usage error instead of a valid annotated VCF. Guard on len(pcgr_vcf_files) == 1: copy the single chunk's VCF directly to the expected merged-output path and tabix-index it, matching the indexed .vcf.gz contract that merge_vcf_files normally produces. Two or more chunks still go through the existing bcftools merge -> sort -> index path unchanged.
- Remove stray blank first line in bolt/common/pcgr.py - Reword comment in report.py to reference MAX_SOMATIC_VARIANTS constant instead of hardcoded '500,000' value
qclayssen
added a commit
that referenced
this pull request
Jul 21, 2026
Explain why the threshold is 450k (not 500k): PCGR's hard cap is 500k, the 50k margin avoids edge-case overflows during tiered filtering. Notes this was an oral team decision with no written Slack thread. Addresses Stephen's review comment on constants.py:7.
qclayssen
added a commit
that referenced
this pull request
Jul 21, 2026
Explain why the threshold is 450k (not 500k): PCGR's hard cap is 500k, the 50k margin avoids edge-case overflows during tiered filtering. Notes this was an oral team decision with no written Slack thread. Addresses Stephen's review comment on constants.py:7.
qclayssen
added a commit
that referenced
this pull request
Jul 21, 2026
Explain why the threshold is 450k (not 500k): PCGR's hard cap is 500k, the 50k margin avoids edge-case overflows during tiered filtering. Notes this was an oral team decision with no written Slack thread. Addresses Stephen's review comment on constants.py:7.
qclayssen
force-pushed
the
release/0.3.1-validated
branch
from
July 21, 2026 23:22
8f2d975 to
b463534
Compare
qclayssen
added a commit
that referenced
this pull request
Jul 21, 2026
Explain why the threshold is 450k (not 500k): PCGR's hard cap is 500k, the 50k margin avoids edge-case overflows during tiered filtering. Notes this was an oral team decision with no written Slack thread. Addresses Stephen's review comment on constants.py:7.
qclayssen
added a commit
that referenced
this pull request
Jul 21, 2026
Explain why the threshold is 450k (not 500k): PCGR's hard cap is 500k, the 50k margin avoids edge-case overflows during tiered filtering. Notes this was an oral team decision with no written Slack thread. Addresses Stephen's review comment on constants.py:7.
qclayssen
added a commit
that referenced
this pull request
Jul 21, 2026
Explain why the threshold is 450k (not 500k): PCGR's hard cap is 500k, the 50k margin avoids edge-case overflows during tiered filtering. Notes this was an oral team decision with no written Slack thread. Addresses Stephen's review comment on constants.py:7.
qclayssen
force-pushed
the
release/0.3.1-validated
branch
from
July 21, 2026 23:34
b463534 to
8f264d9
Compare
Explain why the threshold is 450k (not 500k): PCGR's hard cap is 500k, the 50k margin avoids edge-case overflows during tiered filtering. Notes this was an oral team decision with no written Slack thread. Addresses Stephen's review comment on constants.py:7.
qclayssen
added a commit
that referenced
this pull request
Jul 21, 2026
Explain why the threshold is 450k (not 500k): PCGR's hard cap is 500k, the 50k margin avoids edge-case overflows during tiered filtering. Notes this was an oral team decision with no written Slack thread. Addresses Stephen's review comment on constants.py:7.
qclayssen
force-pushed
the
release/0.3.1-validated
branch
from
July 21, 2026 23:46
8f264d9 to
1a2a5ca
Compare
qclayssen
added a commit
that referenced
this pull request
Jul 22, 2026
All 11 conflicts resolved by taking release/0.3.0 (0.3.2) content: - Version bumps (.bumpversion.cfg, pyproject.toml, constants.py): keep 0.3.2 - CHANGELOG.md: keep full 0.3.2 history - build.yaml: keep pinned action version (v1.3.0) - logging_config.py: keep force=True addition - pcgr.py, util.py, annotate.py, report.py, rescue.py: keep 0.3.2 implementations Main only had the 0.3.1-validated subset (merged via #35); release/0.3.0 is strictly ahead with all 0.3.2 development work.
qclayssen
added a commit
that referenced
this pull request
Jul 22, 2026
Conflicts resolved by taking oa-only-v2 content (superset of main): - CHANGELOG.md, constants.py, pcgr.py, report.py, test_pcgr_hypermutated.py
qclayssen
added a commit
that referenced
this pull request
Jul 22, 2026
…nts) Merge resolution strategy: - Version/config (.bumpversion.cfg, pyproject.toml, build.yaml, CHANGELOG): take ours (0.3.2) - constants.py: take ours + add MAX_SOMATIC_VARIANTS rationale comment from #35 review - pcgr.py: take ours (has _normalise_tier, drops --estimate_signatures per sash#57) + incorporate documentation comments from #35 review - util.py: take ours + add logging setup comment - logging_config.py: take ours (force=True fix) - annotate.py, report.py, rescue.py: take ours + add review comments - docs/adr/001-max-somatic-variants-450k.md: new from main (kept) - tests/test_pcgr_hypermutated.py: new from main (kept)
qclayssen
added a commit
that referenced
this pull request
Jul 22, 2026
…nts) Merge resolution strategy: - Version/config (.bumpversion.cfg, pyproject.toml, build.yaml, CHANGELOG): take ours (0.3.2) - constants.py: take ours + add MAX_SOMATIC_VARIANTS rationale comment from #35 review - pcgr.py: take ours (has _normalise_tier, drops --estimate_signatures per sash#57) + incorporate documentation comments from #35 review - util.py: take ours + add logging setup comment - logging_config.py: take ours (force=True fix) - annotate.py, report.py, rescue.py: take ours + add review comments - docs/adr/001-max-somatic-variants-450k.md: new from main (kept) - tests/test_pcgr_hypermutated.py: new from main (kept)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.3.1tag, matching theghcr.io/umccr/bolt:0.3.1*images already run against real ICA data.## 0.3.1section for the full list of fixes.Validation
Test plan
v0.3.1already built and validated via ICA runs