ci: add workflow_dispatch dev release for sash #52 E2E testing - #103
Draft
qclayssen wants to merge 3 commits into
Draft
ci: add workflow_dispatch dev release for sash #52 E2E testing#103qclayssen wants to merge 3 commits into
qclayssen wants to merge 3 commits into
Conversation
Regression guard: 563f946 accidentally re-introduced required=TRUE, causing crashes on samples without DRAGEN HRD files.
Builds and pushes linux/amd64 Docker image to docker.io on demand. Requires DOCKERHUB_USERNAME and DOCKERHUB_TOKEN repo secrets.
…b account Original workflow logged into docker.io using DOCKERHUB_USERNAME/ DOCKERHUB_TOKEN secrets, neither of which is configured on this repo (confirmed via gh secret list) — every run would fail at the login step. It also pushed to a personal Docker Hub account, the same governance anti-pattern flagged as a blocking finding in the sash 0.7.0 release audit (qclayssen/sigrap:0.2.0-dev-7). Switched to ghcr.io/umccr/gpgr using GITHUB_TOKEN, matching the existing deploy.yaml convention exactly — no new secrets needed.
qclayssen
marked this pull request as draft
July 15, 2026 06:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a manually-triggered (
workflow_dispatch) GitHub Actions workflow to build and push a dev Docker image, for E2E-testing sash #52 (PCGR skip on high variant count) fixes before they're formally released.Fixed before opening this PR (caught by review): the original commit logged into
docker.iousingDOCKERHUB_USERNAME/DOCKERHUB_TOKENsecrets — neither is configured on this repo (verified viagh secret list), so every run would have failed at the login step. It also pushed to a personal Docker Hub account, the same anti-pattern flagged as a blocking governance finding in the sash 0.7.0 release audit (qclayssen/sigrap:0.2.0-dev-7). Switched toghcr.io/umccr/gpgrusing the built-inGITHUB_TOKEN, matching this repo's existingdeploy.yamlconvention exactly — no new secrets required.Test plan
deploy.yaml(already in production use)workflow_dispatch— first real trigger will be the actual validation