docs: fix stale 500K hypermutation threshold in cancer report QC table - #104
Open
qclayssen wants to merge 2 commits into
Open
docs: fix stale 500K hypermutation threshold in cancer report QC table#104qclayssen wants to merge 2 commits into
qclayssen wants to merge 2 commits into
Conversation
Regression guard: 563f946 accidentally re-introduced required=TRUE, causing crashes on samples without DRAGEN HRD files.
Actual bolt safety threshold is 450,000 (MAX_SOMATIC_VARIANTS, ADR-001), not 500K.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MAX_SOMATIC_VARIANTS, sash ADR-001), so the doc text was stale.inst/rmd/umccrise/cancer_report.Rmdto say 450K instead of 500K.Context: sash 0.7.1 + bolt 0.3.2 validation (biodaily#227) surfaced this discrepancy while re-confirming the hypermutator handling path. See UMCCR Slack thread: https://umccr.slack.com/archives/C025TLC7D/p1773817713888619?thread_ts=1773276509.471689&cid=C025TLC7D
Test plan