Update InfoBarSamplePage.xaml with more Infos and color as well added…#1027
Update InfoBarSamplePage.xaml with more Infos and color as well added…#1027AryanParashar24 wants to merge 2 commits intounoplatform:masterfrom
Conversation
… to them depending onto the different conditions as founded in the code two more Infos are been added in the code with the colors as well been added inot the code specifying the conditions been faced by the customer or developer based on the status of their sitaution
|
@AryanParashar24 Tests seems to be failing on SamplePages\InfoBarSamplePage.xaml(125,11): Error UXAML0001: The 'winui:InfoBar' start tag on line 115 position 9 does not match the end tag of 'winui:InfoBar.Content'. Can you look into it please? |
|
Also @MartinZikmund isn't this one related to #308? 🤔 |
| <Button Style="{StaticResource InformationButtonStyle}" | ||
| Content="DISMISS" /> | ||
| </winui:InfoBar.Content> |
There was a problem hiding this comment.
Missing the winui:InfoBar.Content starting tag
|
|
'winui:InfoBar' start tag has been added in to the code which was missing from the file hope it solves out the issue now
|
Hey @morning4coffe-dev @mrlacey plz le me know if it could be improved a bit more by changing anything else |
| <Setter Property="Background" Value="Yellow" /> | ||
| <Setter Property="Foreground" Value="Black" /> | ||
| </Style> | ||
| <!-- Add more styles as needed for different severities --> |
| <StackPanel Spacing="20" | ||
| Margin="0,20,0,0"> | ||
| <Page.Resources> | ||
| <!-- Button Styles --> |
There was a problem hiding this comment.
Is anything lost by not basing these new styles on TextButtonStyle?
Such as Min sizes and different focus visuals?
Is this intentional/deliberate? All you've done is change the styles to use different colors and with no explanation of why.
Not sure if you meant me or @MartinZikmund but I have added some comments. |
5 participants
… to them depending onto the different conditions as founded in the code
two more Infos are been added in the code with the colors as well been added inot the code specifying the conditions been faced by the customer or developer based on the status of their sitaution
GitHub Issue (If applicable): #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):