Skip to content

feat: Add Proximity sample#1028

Open
muhmuhhum wants to merge 4 commits intounoplatform:masterfrom
muhmuhhum:master
Open

feat: Add Proximity sample#1028
muhmuhhum wants to merge 4 commits intounoplatform:masterfrom
muhmuhhum:master

Conversation

@muhmuhhum
Copy link
Copy Markdown

@muhmuhhum muhmuhhum commented Oct 12, 2023

GitHub Issue (If applicable): closes #1026

PR Type

What kind of change does this PR introduce?

  • Feature Sample Page for Proximity Sensor

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

Other information

Internal Issue (If applicable):

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Oct 12, 2023

CLA assistant check
All committers have signed the CLA.

@muhmuhhum
Copy link
Copy Markdown
Author

muhmuhhum commented Oct 12, 2023

ok so this is a WIP cause i cant test it on my android emulator.
The app just wont start and i cant really find out why.
So i currently start the app in debug with any cpu and the mobile project.
I also changed IsUiAutomationEnabled in the csproj to false
@morning4coffe-dev maybe you could help me out with this.

@muhmuhhum muhmuhhum marked this pull request as ready for review October 16, 2023 07:38
@muhmuhhum muhmuhhum changed the title WIP feat: Add Proximity sample feat: Add Proximity sample Oct 16, 2023
@morning4coffe-dev
Copy link
Copy Markdown
Member

@muhmuhhum Thanks! Can you please check if it works on Windows (you can add || !HAS_UNO next to the __ANDROID__)? And also sync your branch with current master?

@muhmuhhum
Copy link
Copy Markdown
Author

@morning4coffe-dev Windows is now tested, added the !HAS_UNO and merged the current master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add sample for ProximitySensor

3 participants