Skip to content

fix: TabbarItem with Neumorphic Style crash on Windows#1116

Merged
agneszitte merged 3 commits intomasterfrom
dev/doti/tbi-ns-crash-fix
Jun 17, 2024
Merged

fix: TabbarItem with Neumorphic Style crash on Windows#1116
agneszitte merged 3 commits intomasterfrom
dev/doti/tbi-ns-crash-fix

Conversation

@morning4coffe-dev
Copy link
Copy Markdown
Member

GitHub Issue (If applicable): closes #1106

PR Type

What kind of change does this PR introduce?

  • Bugfix

This should fix the issue with #1106, once this unoplatform/uno.toolkit.ui#1142 PR is merged.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested on iOS.
  • Tested on Wasm.
  • Tested on Android.
  • Tested on UWP.
  • Tested in both Light and Dark themes.
  • Associated with an issue (GitHub or internal)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 4, 2024

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1116.eastus2.3.azurestaticapps.net

@github-actions
Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1116.eastus2.3.azurestaticapps.net

@morning4coffe-dev morning4coffe-dev marked this pull request as ready for review June 16, 2024 21:06
@github-actions
Copy link
Copy Markdown

Azure Static Web Apps: Your stage site is ready! Visit it here: https://white-field-08c5cf00f-1116.eastus2.3.azurestaticapps.net

@morning4coffe-dev
Copy link
Copy Markdown
Member Author

This PR fixes the crash TabBar and FAB Neumorphic sample on Windows. The InfoBadge is currently not used within the Neumorphic sample.

@kazo0
Copy link
Copy Markdown
Contributor

kazo0 commented Jun 17, 2024

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@agneszitte agneszitte merged commit 163d3ca into master Jun 17, 2024
@agneszitte agneszitte deleted the dev/doti/tbi-ns-crash-fix branch June 17, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Gallery][Windows][ShadowContainer] Crash on selection of Tabbar Neumorphic Style dropdown toolkit sample page.

4 participants