Skip to content

chore(Commerce): Update version and UnoFeatures#891

Open
DevTKSS wants to merge 1 commit intounoplatform:masterfrom
DevTKSS:update-commerce
Open

chore(Commerce): Update version and UnoFeatures#891
DevTKSS wants to merge 1 commit intounoplatform:masterfrom
DevTKSS:update-commerce

Conversation

@DevTKSS
Copy link
Copy Markdown

@DevTKSS DevTKSS commented Jul 31, 2025

  • Commerce App global.json Uno.Sdk version has been updated
  • UnoFeatures: removed ExtensionsCore as this is no public documented / introduced Feature (maybe meanwhile already included in the sdk?)
  • Packages for Refit has been pulled in in the dependencys, but only Http UnoFeature has been set in the list
  • Updated Windows PublishProfiles to the Dir where the current templates store them

chore: Update Windows PublishProfiles to the Dir where the current templates store them

Packages has been referencing Refit, but we only had http as feature
Should be checked, if MacCatalyst is still a valid Platform to have in the Platforms folder and TargetFrameworks list
Copilot AI review requested due to automatic review settings July 31, 2025 11:26
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Commerce reference application to use a newer version of the Uno SDK and refines its feature configuration. The changes focus on modernizing the SDK version, improving UnoFeatures configuration, and updating build settings.

  • Updated Uno.Sdk from version 6.0.67 to 6.1.23
  • Added HttpRefit feature and commented out ExtensionsCore feature
  • Updated target framework ordering and resource copy settings

Reviewed Changes

Copilot reviewed 2 out of 5 changed files in this pull request and generated 1 comment.

File Description
reference/Commerce/src/global.json Updates Uno.Sdk version and removes outdated comment
reference/Commerce/src/Commerce/Commerce.csproj Adds HttpRefit feature, comments out ExtensionsCore, reorders target frameworks, and changes resource copy behavior

Comment on lines +44 to +46
Navigation;
<!--ExtensionsCore;-->
SkiaRenderer;
Copy link

Copilot AI Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider removing the commented-out ExtensionsCore feature entirely rather than leaving it as a comment, as this reduces code clutter and confusion about whether it should be enabled.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Team should verify its not longer needed please

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jen-Uno do we want to remove this entirely even if its available?
e.g. I am frequently using it in Library Apps managed by the Uno.Sdk for the Uno Specialized Collection/Enumerable Extensions to have the Uno.Sdk automatically add the nuget to my project 🤔 Would be really sad if Uno really wants to remove this Feature entirely 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants