Skip to content

chore(chat-signalr): modernize signalr sample setup#911

Open
Jen-Uno wants to merge 2 commits intomasterfrom
chore/chat-signalr-modernize-22607
Open

chore(chat-signalr): modernize signalr sample setup#911
Jen-Uno wants to merge 2 commits intomasterfrom
chore/chat-signalr-modernize-22607

Conversation

@Jen-Uno
Copy link
Copy Markdown

@Jen-Uno Jen-Uno commented Mar 6, 2026

Summary

Modernizes the official UI/ChatSignalR sample to align with the updated SignalR guidance and reduce onboarding confusion around server/client setup.

What changed

  • Migrated UnoChat.Service hosting from Startup.cs to minimal API in Program.cs
  • Removed obsolete Startup.cs
  • Standardized hub endpoint usage to https://localhost:7167/chatHub across:
    • Uno client (UnoChat/Presentation/ViewModel.cs)
    • Console client (UnoChat.Client.Console/Program.cs)
  • Refreshed UI/ChatSignalR/README.md with current docs links and quick-start steps

Validation

  • dotnet build UI/ChatSignalR/src/UnoChat.Service/UnoChat.Service.csproj
  • dotnet build UI/ChatSignalR/src/UnoChat.Client.Console/UnoChat.Client.Console.csproj

Related to unoplatform/uno#22607
Fixes #910

Update ChatSignalR sample to align with current SignalR guidance:
- migrate service hosting to minimal API in Program.cs
- remove obsolete Startup.cs
- standardize hub endpoint to /chatHub across clients
- refresh README links and quick-start instructions
@Jen-Uno Jen-Uno requested review from nickrandolph and rajamatt March 6, 2026 17:39
@rajamatt rajamatt requested review from Copilot and removed request for nickrandolph and rajamatt March 9, 2026 12:42
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Modernizes the UI/ChatSignalR sample’s SignalR server hosting and aligns all clients/docs on a single hub endpoint to reduce setup friction and follow current ASP.NET Core guidance.

Changes:

  • Migrated UnoChat.Service from Startup.cs hosting to minimal API in Program.cs and removed Startup.cs.
  • Standardized hub endpoint casing/path to https://localhost:7167/chatHub across Uno and console clients.
  • Refreshed UI/ChatSignalR/README.md quick-start steps and links.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
UI/ChatSignalR/src/UnoChat/Presentation/ViewModel.cs Updates the Uno client’s SignalR hub URL to the standardized /chatHub endpoint.
UI/ChatSignalR/src/UnoChat.Service/Startup.cs Removes legacy Startup-based hosting configuration.
UI/ChatSignalR/src/UnoChat.Service/Program.cs Introduces minimal API hosting, CORS policy, and maps the hub endpoint.
UI/ChatSignalR/src/UnoChat.Client.Console/Program.cs Updates the console client’s SignalR hub URL to the standardized /chatHub endpoint.
UI/ChatSignalR/README.md Updates documentation and quick-start commands to match the new setup and endpoint.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@rajamatt
Copy link
Copy Markdown
Contributor

rajamatt commented Mar 9, 2026

Build is failing because CI is running on net9.0, but this project is on net8.0.

I see we still have some net8.0 samples in Uno.Samples, but I think CI would fail when opening PRs for them.

@Jen-Uno
Copy link
Copy Markdown
Author

Jen-Uno commented Mar 18, 2026

@agneszitte can you help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modernize ChatSignalR sample to align with updated SignalR docs

3 participants