Open
Conversation
MartinZikmund
force-pushed
the
dev/mazi/mediagallery
branch
from
e689a91 to
1f0282a
Compare
MartinZikmund
force-pushed
the
dev/mazi/mediagallery
branch
from
2c7ab9d to
cb63db8
Compare
agneszitte
reviewed
May 29, 2024
Contributor
There was a problem hiding this comment.
Important
Missing related documentation @MartinZikmund please -> https://github.com/unoplatform/uno.toolkit.ui/tree/main/doc
kazo0
approved these changes
May 29, 2024
...lkit.Samples/Uno.Toolkit.Samples.Shared/Content/Helpers/MediaGalleryHelperSamplePage.xaml.cs
Show resolved
Hide resolved
Xiaoy312
approved these changes
May 29, 2024
Contributor
Xiaoy312
left a comment
Xiaoy312
left a comment
There was a problem hiding this comment.
could use some relevant doc on this
...lkit.Samples/Uno.Toolkit.Samples.Shared/Content/Helpers/MediaGalleryHelperSamplePage.xaml.cs
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Helpers/MediaGallery/MediaGallery.Android.cs
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Helpers/MediaGallery/MediaGallery.Android.cs
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Helpers/MediaGallery/MediaGallery.Android.cs
Outdated
Show resolved
Hide resolved
src/Uno.Toolkit.UI/Helpers/MediaGallery/MediaGallery.Android.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Xiaotian Gu <xiaoyao312@gmail.com> Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
kazo0
reviewed
May 30, 2024
Member
Author
|
@agneszitte docs added |
agneszitte
reviewed
May 31, 2024
|
|
||
| ## Remarks | ||
|
|
||
| This class is designed to work on iOS, Mac Catalyst and Android platforms, utilizing platform-specific implementations for its methods. |
Contributor
There was a problem hiding this comment.
Suggested change
| This class is designed to work on iOS, Mac Catalyst and Android platforms, utilizing platform-specific implementations for its methods. | |
| This class is designed to work on iOS, Mac Catalyst, and Android platforms, utilizing platform-specific implementations for its methods. |
|
|
||
| This class is designed to work on iOS, Mac Catalyst and Android platforms, utilizing platform-specific implementations for its methods. | ||
|
|
||
| The API allows setting the `targetFileName`, which **should ideally be unique** - otherwise the OS will either overwrite an existing file with the same name (Android behavior), or generate a new name instead (iOS behavior). |
Contributor
There was a problem hiding this comment.
Suggested change
| The API allows setting the `targetFileName`, which **should ideally be unique** - otherwise the OS will either overwrite an existing file with the same name (Android behavior), or generate a new name instead (iOS behavior). | |
| The API allows setting the `targetFileName`, which **should ideally be unique** - otherwise the OS will either overwrite an existing file with the same name (Android behavior) or generate a new name instead (iOS behavior). |
|
|
||
| #### Summary | ||
|
|
||
| Checks the user's permission to access the device's gallery. Will trigger the permission request if not already granted. |
Contributor
There was a problem hiding this comment.
Suggested change
| Checks the user's permission to access the device's gallery. Will trigger the permission request if not already granted. | |
| Checks the user's permission to access the device's gallery. It will trigger the permission request if it has not already been granted. |
| <string>This app needs access to the photo gallery for saving photos and videos</string> | ||
| ``` | ||
|
|
||
| If you want to support earlier versions iOS, add the following as well: |
Contributor
There was a problem hiding this comment.
Suggested change
| If you want to support earlier versions iOS, add the following as well: | |
| If you want to support earlier versions of iOS, add the following as well: |
| #endif | ||
| ``` | ||
|
|
||
| ### Copying an application package file to gallery |
Contributor
There was a problem hiding this comment.
Suggested change
| ### Copying an application package file to gallery | |
| ### Copying an application package file to the gallery |
Xiaoy312
approved these changes
May 31, 2024
jeromelaban
reviewed
May 31, 2024
| } | ||
| catch (Exception ex) | ||
| { | ||
| tcs.TrySetResult(ex); |
Member
There was a problem hiding this comment.
Why did you choose to use TrySetResult instead of TrySetException?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes unoplatform/uno#16721, closes #1147
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information
Internal Issue (If applicable):