-
Notifications
You must be signed in to change notification settings - Fork 28
fix: add diagnostic warning when LoadingView Source is never set #1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,126 @@ | ||
| using FluentAssertions; | ||
| using Microsoft.UI.Xaml; | ||
| using Microsoft.UI.Xaml.Controls; | ||
| using Microsoft.UI.Xaml.Media; | ||
| using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
| using System; | ||
| using System.Threading.Tasks; | ||
| using Uno.Toolkit.RuntimeTests.Helpers; | ||
| using Uno.Toolkit.RuntimeTests.Tests.HotReload; | ||
| using Uno.Toolkit.UI; | ||
| using Uno.UI.RuntimeTests; | ||
|
|
||
| namespace Uno.Toolkit.RuntimeTests.Tests; | ||
|
|
||
| /// <summary> | ||
| /// Tests for LoadingView visual state transitions based on Source/ILoadable. | ||
| /// Validates that: | ||
| /// - Null Source keeps the view in Loading state indefinitely (content hidden) | ||
| /// - Source.IsExecuting = false transitions to Loaded state (content visible) | ||
| /// - Source set after template application triggers correct transition | ||
| /// </summary> | ||
| [TestClass] | ||
| [RunsOnUIThread] | ||
| public class LoadingViewTests | ||
| { | ||
| private static ContentPresenter? FindContentPresenter(LoadingView lv) | ||
| { | ||
| // The template's ContentPresenter named "ContentPresenter" is inside a Grid. | ||
| // Walk the visual tree to find it. | ||
| if (VisualTreeHelper.GetChildrenCount(lv) == 0) | ||
| { | ||
| return null; | ||
| } | ||
|
|
||
| var root = VisualTreeHelper.GetChild(lv, 0); // Grid "RootPanel" | ||
| for (var i = 0; i < VisualTreeHelper.GetChildrenCount(root); i++) | ||
| { | ||
| if (VisualTreeHelper.GetChild(root, i) is ContentPresenter cp && cp.Name == "ContentPresenter") | ||
| { | ||
| return cp; | ||
| } | ||
| } | ||
|
|
||
| return null; | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public async Task When_SourceIsNull_Then_RemainsInLoadingState() | ||
| { | ||
| // Arrange: LoadingView with no Source set | ||
| var lv = new LoadingView | ||
| { | ||
| Content = new TextBlock { Text = "Main content" }, | ||
| LoadingContent = new TextBlock { Text = "Loading..." }, | ||
| }; | ||
|
|
||
| // Act: add to visual tree, wait for template | ||
| await UnitTestUIContentHelperEx.SetContentAndWait(lv); | ||
|
|
||
| // Assert: Source is null so view stays in "Loading" state. | ||
| // ContentPresenter starts at Opacity=0 and stays there. | ||
| lv.Source.Should().BeNull(); | ||
|
|
||
| var cp = FindContentPresenter(lv); | ||
| cp.Should().NotBeNull("template should have been applied"); | ||
| cp!.Opacity.Should().Be(0, "ContentPresenter should remain hidden (opacity 0) when Source is null (Loading state)"); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public async Task When_SourceBecomesNotExecuting_Then_TransitionsToLoaded() | ||
| { | ||
| // Arrange: start with Source.IsExecuting = true | ||
| var loadable = new TestLoadable(isExecuting: true); | ||
| var lv = new LoadingView | ||
| { | ||
| Source = loadable, | ||
| Content = new TextBlock { Text = "Main content" }, | ||
| LoadingContent = new TextBlock { Text = "Loading..." }, | ||
| UseTransitions = false, // skip animation for deterministic assertion | ||
| }; | ||
|
|
||
| await UnitTestUIContentHelperEx.SetContentAndWait(lv); | ||
|
|
||
| var cp = FindContentPresenter(lv); | ||
| cp.Should().NotBeNull(); | ||
| cp!.Opacity.Should().Be(0, "content should be hidden while Source is executing"); | ||
|
|
||
| // Act: transition to not-executing | ||
| loadable.IsExecuting = false; | ||
| await UnitTestUIContentHelperEx.WaitForIdle(); | ||
|
|
||
| // Assert: "Loaded" visual state sets ContentPresenter.Opacity = 1 | ||
| cp.Opacity.Should().Be(1, | ||
| "ContentPresenter should become visible (opacity 1) after Source stops executing"); | ||
| } | ||
|
|
||
| [TestMethod] | ||
| public async Task When_SourceSetAfterTemplate_Then_TransitionsCorrectly() | ||
| { | ||
| // Arrange: LoadingView initially with no Source | ||
| var lv = new LoadingView | ||
| { | ||
| Content = new TextBlock { Text = "Main content" }, | ||
| LoadingContent = new TextBlock { Text = "Loading..." }, | ||
| UseTransitions = false, | ||
| }; | ||
|
|
||
| await UnitTestUIContentHelperEx.SetContentAndWait(lv); | ||
|
|
||
| var cp = FindContentPresenter(lv); | ||
| cp.Should().NotBeNull(); | ||
|
|
||
| // Precondition: Source is null → Loading state → content hidden | ||
| lv.Source.Should().BeNull(); | ||
| cp!.Opacity.Should().Be(0); | ||
|
|
||
| // Act: set Source to an already-completed loadable | ||
| var loadable = new TestLoadable(isExecuting: false); | ||
| lv.Source = loadable; | ||
| await UnitTestUIContentHelperEx.WaitForIdle(); | ||
|
|
||
| // Assert: transitions to Loaded → content visible | ||
| cp.Opacity.Should().Be(1, | ||
| "ContentPresenter should become visible after Source is set with IsExecuting=false"); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.