Docs(docfx): update docfx build locally guide and apply xref links#19722
Docs(docfx): update docfx build locally guide and apply xref links#19722DevTKSS wants to merge 13 commits intounoplatform:masterfrom
Conversation
|
|
|
The markdown linting pipeline in this case would be greatly more helpful if it would also lint and suggest the solution for image video and links like relative paths and so on before the intending and spaces checks👍🤔 |
|
|
|
Currently on Fixing a regex bug, then I will send the updated commits. |
|
Does a include of Pester tests required check the ui tests checkbook above? |
|
@DevTKSS Thank you so much for the Pull Request ❤️ |
|
Status update: Things might to consider for add able tests and function for uid-xref links:
Currently checking on the dot sourcing third script now which should be last before again check on the main script which uses them. The dot sourcing one might be the most difficult one to setup test for because it has no actual function definition right now, just what it should execute. If it works but test setup has still trouble with its validation I would consider updating the related docs on it and commit to the remote branch so its review-able and maybe get a overseen solution for this. Since I did add those md files, I did sort them into directory and recognized that not really matching and seperated directorys. Seems like there is the main contributing one and the uno-development one which mainly contains all of the files nested in toc contributing😅 And I am thinking of, if the scripts might be better places to the testscrips folder instead(paths naturally fitted) to not cloud the documentation itself? |
|
@agneszitte @MartinZikmund commited to remote, unable to fix the Import-TocCheckerUtils.Test.ps1 to pass the check of Get-MarkdownHeader function, while it passed the dot-sourcing before. checking this here: It should have been able to get it from my point of view. |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
|
ToDo List to be checked:
|
doc/articles/contributing/guidelines/creating-ps-pester-tests.md
Outdated
Show resolved
Hide resolved
doc/articles/contributing/guidelines/creating-ps-pester-tests.md
Outdated
Show resolved
Hide resolved
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
|
work still in progress |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
1 similar comment
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/index.html |
dcc12c5 to
8d6e32f
Compare
|
|
|
|
|
checked the "Run spell checking" pipeline problems, seems the CI needs some external help to ignore this or tell me and I switch the xref Names there, but since that are not my created ones and most likly be linked at some places, I would prefer decision from the team for this... Lines: Post Edit Note: Renaming has been applyed for xref of 1-3, others got added to cspell. See this commit for details |
|
|
|
|
|
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19722/index.html |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
|
@Jen-Uno can you give me some state update on this or what I might need to change to get this finished up and merged/dropped? |
chore: Add Information about the v6 Extension improvements
…ation locally chore: Fixed outdated link for tabs to the docfx documentation docs(tabs): Added information about ending tab content docs(formatted-blockquotes): Added rendered samples for the mentioned formatted blockquotes beside note chore: Fixed formatting and seperated contributors note to CI in note
chore: Listed both common ways to serve docfx output locally docs(ImportExternalDocs): Added import of the README.md from Extensions Repository This provides clarity of usage of the import_external_docs scripts available in the main documentation to lookup
chore(anchor-links): title moved out of metadata chore(doc-templates): Added uid to templates for xref usage chore(contributing): Updated most of the contribution specific md files directory to match their namespace Co-authored-by: Agnès ZITTE <16295702+agneszitte@users.noreply.github.com>
…xref usage using xref makes the toc independant on where the file is actually placed
Rider Android Support is reported as incompatible as of 06.02.2025 should get checked and until then removed
…ut vs code extensions
chore: moved the gif file to the assets folder near to the file its used with chore: added the Anchor Links Link to the toc used replace in vs code which should have found all occurrences
7670f57 to
d073ff9
Compare
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Uno Platform documentation to modernize the docfx build instructions and extensively applies xref cross-reference links throughout the documentation structure. The main changes focus on improving documentation maintainability and navigation.
Key Changes
- Updated docfx build commands from deprecated
docfx.consoleto currentdocfxtool - Converted numerous hard-coded documentation links to xref references for better maintainability
- Added multiple new documentation files covering topics like native views, native styles, composition API, performance, and more
- Restructured the table of contents (toc.yml) with improved organization and xref links
- Fixed casing inconsistency in code comments ("DocFx" → "docfx")
Reviewed Changes
Copilot reviewed 57 out of 139 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| doc/templates/uno/service/search.js | Fixed casing of "docfx" in comment (spelling correction) |
| doc/templates/uno/styles/docfx.js.map | Regenerated minified JavaScript map file |
| doc/index.md | Updated link to debugging guide using xref |
| doc/articles/uno-development/*.md | Added extensive new documentation files for native features, composition, performance, etc. |
| doc/articles/toc.yml | Major restructuring with xref links replacing hard-coded paths |
| doc/articles/getting-started/*.md | Added licensing documentation and supporting assets |
| doc/articles/features/windows-ui-markup-extensions.md | Removed trailing whitespace |
| Multiple PNG files | Added new screenshot assets for documentation |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/docs/index.html |
…ted folder to fix the image links Also updated the `/includes/` links to keep the file sourcing working
🤔 not really added those files, I just moved to the appropriate location if not already there. like creating Latest updates do introduce compared to the previously seen ones:
@Jen-Uno seeing your - #21828 so maybe you might want to cherry pick those movement commits until the team finds time to review this? 🚀 |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19722/docs/index.html |
|
@Jen-Uno seeing you create another docfx PR, so seems like this PR here is now obsolete? Would you be able to check if a rebase &update would make any longer sense or you just cherry pick what you need and we can have this closed in any future? its now open for month and not really funny to see PR + PR of the team doing the same themselfs and not noticing this any longer. 😅 |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Current docfx guide is outdated and telling to use docfx.console which has been depreciated
see more Information to this here: dotnet/docfx#9100
Link to the Documentation page
The Uno.Extensions Repository is already having the new commands in its Readme.md
Secondary, the check_toc.ps1 does list almoast every href as not linked to a file, because it does not recognize the xref link declaration
Third page is way smaller changes:
What is the new behavior?
Updated the docfx commands
Problem with that is, I do not understand the UWPSyncGenerator so deeply to decide this. Currently, those comments do stretch the md line distance a bit (vs 2022 preview) althought its hidden.
Added a detailed guide to the usage of check_toc.ps1 along with adding the capability of recognizing and comparing the xref -> uids
The old one does have a different signature...
At the moment it's not part of the CI,so I dont know it should be tested for this again...PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults. -> building docfx is failing because of missing things it seems to medocfx build output.txt
Other information
Above mentioned
Internal Issue (If applicable):