This repository was archived by the owner on Oct 10, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 24
WIP Apple VideoToolbox VP9 support - To be merged after Xcode 12 is released #31
Open
jgh-
wants to merge
16
commits into
master
Choose a base branch
from
vp9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
17a3494
Checkpoint
jgh- 34bd1ba
Add comma
jgh- 031555d
Get most of vp9 props
jgh- 5377e55
Merge branch 'master' into vp9
jgh- ef0b2d1
fix videodesc usage
jgh- 6f64dc7
Add argument labels
jgh- 276b56e
FormatDescriptionOut
jgh- ddb0572
keep format description from initial creation
jgh- f352a75
some improvements
jgh- 61a4f62
Fix parsing
jgh- 5999124
fix build
jgh- b453bbe
Register vp9 on macos
jgh- 26cbffe
mark if available
jgh- 1039327
macOS 11.0 not 10.11
jgh- f456259
rm from encoder
jgh- bd6b6e9
do not build macos code
jgh- File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask a question? old h264 we can use
kCMSampleAttachmentKey_DependsOnOthersto determine is keyframe or not, why here is not? sry I don't master the vp9 formate now. https://github.com/jgh-/VideoCore-Inactive/blob/859dc77dbe29a6d052beda92f2d7f407dbd303e7/transforms/Apple/H264Encode.mm#L66