Fix BoolWithInverseFlag.String() panic when no tab in output#2306
Closed
Bahtya wants to merge 1 commit intourfave:mainfrom
Closed
Fix BoolWithInverseFlag.String() panic when no tab in output#2306Bahtya wants to merge 1 commit intourfave:mainfrom
Bahtya wants to merge 1 commit intourfave:mainfrom
Conversation
When FlagStringer returns a string without a tab character, strings.Index returns -1, causing out[i:] to panic with index out of range. Add guard to return the string as-is when no tab is found. Fixes #2303
yassinebenaid
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
FlagStringerreturns a string without a tab character,strings.Index(out, "\t")returns-1. Thenout[i:]panics withindex out of range [-1].Solution
Add guard: if no tab found, return the string as-is.
Fixes #2303