Conversation
Open the sphinx upper bound to <10 so users can install Sphinx 9.
sphinx-needs >=7 is required for that combination; tox matrix already
covers py312-sphinx9-needs{7,8} which pass.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 29 29
Lines 2628 2628
Branches 306 306
=======================================
Hits 2367 2367
Misses 165 165
Partials 96 96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cover Sphinx 9 with the lowest compatible sphinx-needs (7) and the highest (8). sphinx-needs <7 is incompatible with Sphinx 9.
patdhlk
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<9to<10so Sphinx 9 can be installed alongsidesphinx-codelinks.Test plan
tox -e py312-sphinx9-needs7— 206 passedtox -e py312-sphinx9-needs8— 206 passedtox -e py312-sphinx8-needs5— 206 passed (no regression on the existing default env)Notes
Sphinx 9 is incompatible with
sphinx-needs <7(needs 5/6 requiresphinx<9), so users wanting Sphinx 9 will resolve tosphinx-needs >=7. The combinedsphinx-needs>=5,<9constraint stays correct because pip resolves a compatible pair.Some
RemovedInSphinx11Warningdeprecations surface fromsphinx-needsand our extension code (env.appaccess,add_extra_option), but no tests fail on Sphinx 9.