support jinja templates in needs-role-need-template#1698
Open
PhilipPartsch wants to merge 2 commits intouseblocks:masterfrom
Open
support jinja templates in needs-role-need-template#1698PhilipPartsch wants to merge 2 commits intouseblocks:masterfrom
PhilipPartsch wants to merge 2 commits intouseblocks:masterfrom
Conversation
chrisjsewell
requested changes
May 1, 2026
| if ref_name and prefix in ref_name and postfix in ref_name: | ||
| # if ref_name is set and has prefix to process, we will do so. | ||
| ref_name = ref_name.replace(prefix, "{").replace(postfix, "}") | ||
| # Keep the user-facing [[...]] syntax, but render using Jinja. |
Member
There was a problem hiding this comment.
I believe you should be able to do this in a more "proper" way, using this API.
import minijinja
env = minijinja.Environment()
env.variable_start_string = "[["
env.variable_end_string = "]]"Maybe you could add a way to apply this via the compile_template function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of #1697 1697