-
Notifications
You must be signed in to change notification settings - Fork 8
Version SQL functions to v1 #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crystarm
wants to merge
2
commits into
userver-framework:develop
Choose a base branch
from
crystarm:feature/sql-function-versioning
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -161,7 +161,7 @@ END; | |
| $$ | ||
| LANGUAGE plpgsql; | ||
|
|
||
| CREATE OR REPLACE FUNCTION real_medium.create_article(_title varchar(255), _slug varchar(255), _body text, _description text, _user_id text, _tags varchar(255)[]) | ||
| CREATE OR REPLACE FUNCTION real_medium.create_article_v1(_title varchar(255), _slug varchar(255), _body text, _description text, _user_id text, _tags varchar(255)[]) | ||
| RETURNS text | ||
| AS $$ | ||
| DECLARE | ||
|
|
@@ -192,6 +192,15 @@ END; | |
| $$ | ||
| LANGUAGE plpgsql; | ||
|
|
||
| CREATE OR REPLACE FUNCTION real_medium.create_article(_title varchar(255), _slug varchar(255), _body text, _description text, _user_id text, _tags varchar(255)[]) | ||
| RETURNS text | ||
| AS $$ | ||
| BEGIN | ||
| RETURN real_medium.create_article_v1(_title, _slug, _body, _description, _user_id, _tags); | ||
| END; | ||
| $$ | ||
| LANGUAGE plpgsql; | ||
|
|
||
| CREATE OR REPLACE FUNCTION real_medium.is_favorited_article(_article_id text, _user_id text = NULL) | ||
| RETURNS bool | ||
| AS $$ | ||
|
|
@@ -217,7 +226,7 @@ BEGIN | |
| username, | ||
| bio, | ||
| image, | ||
| CASE WHEN _follower_id = NULL THEN | ||
| CASE WHEN _follower_id IS NULL THEN | ||
| FALSE | ||
| ELSE | ||
| real_medium.is_following(_id, _follower_id) | ||
|
|
@@ -230,7 +239,7 @@ END; | |
| $$ | ||
| LANGUAGE plpgsql; | ||
|
|
||
| CREATE OR REPLACE FUNCTION real_medium.get_article_with_author_profile(_article_id text, _follower_id text = NULL) | ||
| CREATE OR REPLACE FUNCTION real_medium.get_article_with_author_profile_v1(_article_id text, _follower_id text = NULL) | ||
| RETURNS SETOF real_medium.tagged_article_with_author_profile | ||
| AS $$ | ||
| BEGIN | ||
|
|
@@ -259,7 +268,20 @@ END; | |
| $$ | ||
| LANGUAGE plpgsql; | ||
|
|
||
| CREATE OR REPLACE FUNCTION real_medium.get_article_with_author_profile_by_slug(_slug varchar(255), _follower_id text = NULL) | ||
| CREATE OR REPLACE FUNCTION real_medium.get_article_with_author_profile(_article_id text, _follower_id text = NULL) | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just use |
||
| RETURNS SETOF real_medium.tagged_article_with_author_profile | ||
| AS $$ | ||
| BEGIN | ||
| RETURN QUERY | ||
| SELECT | ||
| * | ||
| FROM | ||
| real_medium.get_article_with_author_profile_v1(_article_id, _follower_id); | ||
| END; | ||
| $$ | ||
| LANGUAGE plpgsql; | ||
|
|
||
| CREATE OR REPLACE FUNCTION real_medium.get_article_with_author_profile_by_slug_v1(_slug varchar(255), _follower_id text = NULL) | ||
| RETURNS SETOF real_medium.tagged_article_with_author_profile | ||
| AS $$ | ||
| DECLARE | ||
|
|
@@ -296,6 +318,19 @@ END; | |
| $$ | ||
| LANGUAGE plpgsql; | ||
|
|
||
| CREATE OR REPLACE FUNCTION real_medium.get_article_with_author_profile_by_slug(_slug varchar(255), _follower_id text = NULL) | ||
| RETURNS SETOF real_medium.tagged_article_with_author_profile | ||
| AS $$ | ||
| BEGIN | ||
| RETURN QUERY | ||
| SELECT | ||
| * | ||
| FROM | ||
| real_medium.get_article_with_author_profile_by_slug_v1(_slug, _follower_id); | ||
| END; | ||
| $$ | ||
| LANGUAGE plpgsql; | ||
|
|
||
| CREATE OR REPLACE FUNCTION real_medium.get_feed_articles(_user_id text, _limit int = 20, _offset int = 0) | ||
| RETURNS SETOF real_medium.tagged_article_with_author_profile | ||
| AS $$ | ||
|
|
@@ -400,5 +435,3 @@ LANGUAGE plpgsql; | |
| CREATE INDEX IF NOT EXISTS idx_createdat ON real_medium.articles(created_at DESC); | ||
|
|
||
| CREATE INDEX IF NOT EXISTS idx_tagname ON real_medium.tag_list(tag_name); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just use
create_article_v1directly in code and remove thecreate_article