Add Dutch locale label#722
Draft
huulie wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
The community skeleton can enable locales through the
app_localesparameter. A companion community-skeleton PR adds Dutch (nl) translations and enablesnl, but core-framework currently does not includenlin the locale label map returned byUVDeskService::getLocalesList().When
nlis active,UVDeskService::getLocales()attempts to read$localesList["nl"], which causes an undefined array key warning while rendering the sidebar language selector.2. What does this change do, exactly?
Adds Dutch (
nl) to the core-framework locale label map:nlis labeled withtrans("Dutch").3. Please link to the relevant issues (if any).