Reuse GenBonded parameter lookups - #500
Open
kierandidi wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #500 +/- ##
===========================================
+ Coverage 74.11% 92.42% +18.30%
===========================================
Files 455 456 +1
Lines 40173 40255 +82
===========================================
+ Hits 29775 37204 +7429
+ Misses 10398 3051 -7347
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default 142 residue types issue 7,574 torsion queries with only 359 unique keys and 562 improper queries with only 47 unique keys. The two small per-term dictionaries remove those repeated hierarchy and permutation searches without global state, device branches, or changes to score-term controls.
Performance
Exact post-#499, alternating three-process medians:
H200 peak allocation is unchanged at 41,096,192 bytes.
A follow-up that also cached assembled parameter rows was rejected: it improved CPU complete term setup by only 0.3% and regressed the noisy H200 median. This PR retains the smaller lookup-only cache.
Validation
Benchmark drivers, profiles, and outputs remain external to the repository.