implement a global menubar

data/yad.1

@@ -86,6 +86,9 @@ Set the dialog title.
 .B \-\-window-icon=\fIICON\fP
 Set the window icon.
 .TP
+.B \-\-menubar=\fISTRING\fP
+Add a main menu bar to the top of the dialog window. This is distinct from the notification tray menu. See \fBMENU BAR\fP section for the syntax of \fISTRING\fP.
+.TP
 .B \-\-width=\fIWIDTH\fP
 Set the dialog window width.
 .TP
@@ -1228,6 +1231,59 @@ Separator character for menu items (e.g. `!') sets with \-\-item-separator argum
 .B quit
 Exit the program. Middle click on icon also send \fIquit\fP command.
 
+.SH MENU BAR
+The \fB\-\-menubar\fR option adds a standard hierarchical menu bar to the top of the dialog window. This menu is processed as a stack, allowing for deeply nested submenus.
+
+The \fISTRING\fR is a comma-separated list of entries defined by the following syntax:
+
+.SS Item Syntax
+.TP
+\fBRoot Menu\fR
+.B label[;;]
+A root menu heading on the bar. It must end with two semicolons to distinguish it from standard menu items.
+.TP
+\fBMenu Item\fR
+.B label [| command [| icon/type]]
+The standard format for items within a menu.
+.RS
+.IP \(bu 2
+\fBlabel\fR: The text displayed. Use an underscore (\fB_\fR) before a character to create a mnemonic (e.g., \fI_File\fR). \fByad\fR automatically validates mnemonics at each level; if a character is already in use, the underscore is stripped to prevent focus conflicts. Use \fB__\fR for a literal underscore.
+.IP \(bu 2
+\fBcommand\fR: The shell command to execute. If this field is omitted or empty, the item is treated as a \fBSubmenu\fR opener.
+.IP \(bu 2
+\fBicon/type\fR: Either a themed icon name, a path to an image, or the keyword \fBcheck\fR. If \fBcheck\fR is used, the item becomes a toggleable checkbox and executes the command upon every state change.
+.RE
+
+.SS Special Commands
+The following keywords can be used in the \fIcommand\fR field for built-in functionality:
+.TP
+\fBquit\fR or \fBexit\fR
+Closes the \fByad\fR dialog immediately.
+
+.SS Hierarchy Control
+.TP
+\fBSubmenus\fR
+A submenu is opened by providing a \fBlabel\fR without a \fBcommand\fR. All subsequent items in the string will be placed inside this submenu.
+.TP
+\fBClosing Levels\fR
+An empty entry (indicated by two consecutive commas \fB, ,\fR) pops the menu stack, closing the current submenu and returning to the previous level.
+.TP
+\fBSeparators\fR
+An entry with an empty label or a single dash (\fB\-\fR) creates a horizontal separator line.
+
+.SS Examples
+.PP
+\fB1. Standard File and Edit setup:\fR
+.nf
+yad \-\-menubar="_File;;_New|touch n.txt|document-new, _Quit|exit|gtk-quit, _Edit;;_Undo|undo-cmd|edit-undo"
+.fi
+
+.PP
+\fB2. Nested submenus and Checkboxes:\fR
+.nf
+yad \-\-menubar="_Settings;;_View|, _Toolbar||check, \-, _Statusbar||check, , _Network|, _Wifi|nm-applet|network-wireless, , _Quit|quit|gtk-quit"
+.fi
+
 .SH STOCK ITEMS
 .TP
 This is a list of predefined items available in \fIyad\fP.

src/Makefile.am

@@ -30,6 +30,8 @@ yad_SOURCES = 		\
 	text.c			\
 	util.c			\
 	main.c			\
+	menu.c			\
+	menu.h			\
 	yad.h			\
 	calendar.xpm	\
 	$(CPICKER_SOURCES)

src/main.c

@@ -31,6 +31,7 @@
 # include <gdk/gdkx.h>
 #endif
 
+#include "menu.h"
 #include "yad.h"
 
 YadOptions options;
@@ -454,6 +455,16 @@ create_dialog (void)
   vbox = gtk_box_new (GTK_ORIENTATION_VERTICAL, 2);
   gtk_container_add (GTK_CONTAINER (dlg), vbox);
 
+  if (options.data.dialog_menu && strlen(options.data.dialog_menu) > 0) {
+    GtkWidget *toolbar_box = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
+    GtkWidget *menubar = yad_build_global_menu(options.data.dialog_menu);
+    if (menubar) {
+        gtk_box_pack_start(GTK_BOX(toolbar_box), menubar, FALSE, FALSE, 0);
+        gtk_box_pack_start(GTK_BOX(vbox), toolbar_box, FALSE, FALSE, 0);
+
+    }
+  }
+
   layout = create_layout (dlg);
 
   /* create timeout indicator widget */

src/menu.c

@@ -0,0 +1,276 @@
+#include "menu.h"
+#include "yad.h"
+#include <string.h>
+#include <ctype.h>
+
+
+/* ===========================
+   DATA STRUCTURES
+   =========================== */
+
+typedef struct _MenuItem {
+    gchar *label;
+    gchar *command;
+    gchar *icon_name;
+
+    gboolean is_submenu;
+    gboolean is_check;
+    gboolean checked;
+    gboolean is_separator;
+
+    GList *submenu_items;
+    GtkWidget *indicator_image; 
+} MenuItem;
+
+typedef struct _RootMenu {
+    gchar *label;
+    GList *items;
+} RootMenu;
+
+static GList *root_menus = NULL;
+static GList *menu_stack = NULL;
+
+/* ===========================
+   MEMORY CLEANUP
+   =========================== */
+
+static void free_menu_item(gpointer data) {
+    MenuItem *item = (MenuItem *)data;
+    if (!item) return;
+    g_free(item->label);
+    g_free(item->command);
+    g_free(item->icon_name);
+    if (item->submenu_items) {
+        g_list_free_full(item->submenu_items, free_menu_item);
+    }
+    g_free(item);
+}
+
+static void free_root_menu(gpointer data) {
+    RootMenu *root = (RootMenu *)data;
+    if (!root) return;
+    g_free(root->label);
+    if (root->items) {
+        g_list_free_full(root->items, free_menu_item);
+    }
+    g_free(root);
+}
+
+/* ===========================
+   MNEMONIC SAFETY LOGIC
+   =========================== */
+
+static gchar* validate_mnemonic(const gchar *label, gboolean *used_list) {
+    if (!label) return NULL;
+
+    gchar *new_label = g_strdup(label);
+    gchar *p = strchr(new_label, '_');
+
+    while (p) {
+        unsigned char c = (unsigned char)p[1];
+        if (c != '\0' && c != '_') {
+            int index = toupper(c);
+            if (used_list[index]) {
+                memmove(p, p + 1, strlen(p));
+                p = strchr(p, '_'); 
+            } else {
+                used_list[index] = TRUE;
+                break;
+            }
+        } else {
+            p = strchr(p + 2, '_');
+        }
+    }
+    return new_label;
+}
+
+/* ===========================
+   FORGIVING PARSER
+   =========================== */
+
+static void add_parsed_item(gchar **parts, gint n, RootMenu *current_root, GList **stack, gboolean *used_mnemonics) {
+    MenuItem *item = g_new0(MenuItem, 1);
+
+    // Label is mandatory. Empty or "-" = separator.
+    gchar *raw_label = (n > 0) ? g_strstrip(g_strdup(parts[0])) : g_strdup("");
+
+    if (!*raw_label || g_strcmp0(raw_label, "-") == 0) {
+        item->is_separator = TRUE;
+        g_free(raw_label);
+    } else {
+        item->label = validate_mnemonic(raw_label, used_mnemonics);
+        g_free(raw_label);
+
+        // Command handling: if n > 1 and not empty, it's an action.
+        if (n > 1 && parts[1] && *parts[1]) {
+            item->command = g_strdup(parts[1]);
+            item->is_submenu = FALSE;
+        } else {
+            item->is_submenu = TRUE; 
+        }
+
+        // Icon/Type handling
+        if (n > 2 && parts[2] && *parts[2]) {
+            if (g_ascii_strcasecmp(parts[2], "check") == 0) {
+                item->is_check = TRUE;
+                item->is_submenu = FALSE;
+            } else {
+                item->icon_name = g_strdup(parts[2]);
+            }
+        }
+    }
+
+    GList **target = (*stack) ? &((MenuItem *)(*stack)->data)->submenu_items : &current_root->items;
+    *target = g_list_append(*target, item);
+
+    if (item->is_submenu && !item->command) {
+        *stack = g_list_prepend(*stack, item);
+    }
+}
+
+static void parse_menu_string(const gchar *def) {
+    if (!def) return;
+    gchar **tokens = g_strsplit(def, ",", 0);
+    RootMenu *current_root = NULL;
+    gboolean root_mnemonics[256] = { FALSE };
+    gboolean level_mnemonics[256] = { FALSE };
+
+    for (int i = 0; tokens[i]; i++) {
+        gchar *tok = g_strstrip(g_strdup(tokens[i]));
+        if (!*tok) { 
+            if (menu_stack) {
+                GList *next = menu_stack->next;
+                g_list_free_1(menu_stack);
+                menu_stack = next;
+            }
+            memset(level_mnemonics, 0, sizeof(level_mnemonics));
+            g_free(tok);
+            continue;
+        }
+
+        if (g_strrstr(tok, ";;")) { 
+            gchar *p = g_strrstr(tok, ";;");
+            gchar *remainder = p + 2;
+            *p = 0;
+            gchar *root_label = g_strstrip(tok);
+            if (*root_label) {
+                current_root = g_new0(RootMenu, 1);
+                current_root->label = validate_mnemonic(root_label, root_mnemonics);
+                root_menus = g_list_append(root_menus, current_root);
+                menu_stack = NULL;
+                memset(level_mnemonics, 0, sizeof(level_mnemonics));
+
+                if (*remainder) {
+                    gchar **parts = g_strsplit(remainder, "|", 3);
+                    add_parsed_item(parts, g_strv_length(parts), current_root, &menu_stack, level_mnemonics);
+                    g_strfreev(parts);
+                }
+            }
+        } else if (current_root) { 
+            gchar **parts = g_strsplit(tok, "|", 3);
+            add_parsed_item(parts, g_strv_length(parts), current_root, &menu_stack, level_mnemonics);
+            g_strfreev(parts);
+        }
+        g_free(tok);
+    }
+    g_strfreev(tokens);
+}
+
+/* ===========================
+   UI GENERATION
+   =========================== */
+
+static void mb_activate(GtkWidget *w, gpointer data) {
+    MenuItem *item = (MenuItem *)data;
+    if (!item) return;
+
+    if (GTK_IS_CHECK_MENU_ITEM(w)) {
+        item->checked = gtk_check_menu_item_get_active(GTK_CHECK_MENU_ITEM(w));
+    }
+
+    if (!item->command || strlen(item->command) == 0) {
+        return;
+    }
+
+    // Handle "Quit" or "Exit" internal commands
+   gchar *cmd = g_strstrip(g_strdup(item->command));
+
+    if (g_ascii_strcasecmp(cmd, "quit") == 0 || 
+        g_ascii_strcasecmp(cmd, "exit") == 0) {
+        g_free(cmd);
+        gtk_main_quit();
+        return;
+    }
+
+    run_command_async(cmd);
+
+   g_free(cmd);
+}
+
+static void populate_yad_menu(GtkWidget *menu, GList *items) {
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
+    for (GList *l = items; l; l = l->next) {
+        MenuItem *item = (MenuItem *)l->data;
+        GtkWidget *mi;
+
+        if (item->is_separator) {
+            mi = gtk_separator_menu_item_new();
+        } 
+        else if (item->is_check) {
+            mi = gtk_check_menu_item_new_with_mnemonic(item->label);
+            gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(mi), item->checked);
+        } 
+        else if (item->icon_name) {
+            mi = gtk_image_menu_item_new_with_mnemonic(item->label);
+            GdkPixbuf *pb = get_pixbuf(item->icon_name, YAD_SMALL_ICON, TRUE);
+            if (pb) {
+                GtkWidget *img = gtk_image_new_from_pixbuf(pb);
+                gtk_image_menu_item_set_image(GTK_IMAGE_MENU_ITEM(mi), img);
+                gtk_image_menu_item_set_always_show_image(GTK_IMAGE_MENU_ITEM(mi), TRUE);
+                g_object_unref(pb);
+            }
+        } 
+        else {
+            mi = gtk_menu_item_new_with_mnemonic(item->label);
+        }
+
+        if (item->submenu_items) {
+            GtkWidget *sub = gtk_menu_new();
+            populate_yad_menu(sub, item->submenu_items);
+            gtk_menu_item_set_submenu(GTK_MENU_ITEM(mi), sub);
+        } else {
+            g_signal_connect(mi, "activate", G_CALLBACK(mb_activate), item);
+        }
+
+        if (mi) {
+            gtk_style_context_add_class(gtk_widget_get_style_context(mi), "yad-menu-item");
+        }
+
+        gtk_menu_shell_append(GTK_MENU_SHELL(menu), mi);
+    }
+#pragma GCC diagnostic pop 
+}
+
+GtkWidget* yad_build_global_menu(const gchar *def) {
+    if (!def) return NULL;
+    if (root_menus) {
+        g_list_free_full(root_menus, free_root_menu);
+        root_menus = NULL;
+    }
+
+   parse_menu_string(def);
+
+    GtkWidget *menubar = gtk_menu_bar_new();
+    gtk_style_context_add_class(gtk_widget_get_style_context(menubar), "yad-menubar");
+    for (GList *l = root_menus; l; l = l->next) {
+        RootMenu *root = (RootMenu *)l->data;
+        GtkWidget *root_mi = gtk_menu_item_new_with_mnemonic(root->label);
+        GtkWidget *sub = gtk_menu_new();
+        populate_yad_menu(sub, root->items);
+        gtk_menu_item_set_submenu(GTK_MENU_ITEM(root_mi), sub);
+        gtk_menu_shell_append(GTK_MENU_SHELL(menubar), root_mi);
+    }
+    gtk_widget_show_all(menubar);
+    return menubar;
+}

src/menu.h

@@ -0,0 +1,13 @@
+#ifndef MENU_H
+#define MENU_H
+
+#include <gtk/gtk.h>
+
+/* 
+ * Build a GtkMenu from a hierarchical string.
+ * Example format:
+ * "Settings;;Dark Mode|/bin/toggle_dark|check,Auto-Refresh|/bin/toggle_ref|check"
+ */
+GtkWidget* yad_build_global_menu(const gchar *def);
+
+#endif /* MENU_H */