chore: change short month name for August for consistency with moment.js configuration#6609
Open
crestf wants to merge 4 commits intovalor-software:developmentfrom
Open
chore: change short month name for August for consistency with moment.js configuration#6609crestf wants to merge 4 commits intovalor-software:developmentfrom
crestf wants to merge 4 commits intovalor-software:developmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
I have noticed that ngx-bootstrap uses the 'id' locale configuration, based on moment.js locale configuration. However, there is a difference in the short month name for 'August'—moment.js uses 'Agt,' while ngx-bootstrap uses 'Ags.' This inconsistency leads to a different display in my project, which utilizes both ngx-bootstrap and moment.js configurations.
As an Indonesian myself, I propose following moment.js locale configuration, as it has become more common lately to abbreviate the month name 'August' as 'Agt.'
Reference to moment.js locale configuration: https://github.com/moment/moment/blob/develop/locale/id.js#L19
Reference to ICU locale for Indonesia (id-ID): https://www.localeplanet.com/icu/id-ID/index.html
PR Checklist
Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.