Skip to content

chore: change short month name for August for consistency with moment.js configuration#6609

Open
crestf wants to merge 4 commits intovalor-software:developmentfrom
crestf:development
Open

chore: change short month name for August for consistency with moment.js configuration#6609
crestf wants to merge 4 commits intovalor-software:developmentfrom
crestf:development

Conversation

@crestf
Copy link
Copy Markdown

@crestf crestf commented Sep 15, 2023

Description:
I have noticed that ngx-bootstrap uses the 'id' locale configuration, based on moment.js locale configuration. However, there is a difference in the short month name for 'August'—moment.js uses 'Agt,' while ngx-bootstrap uses 'Ags.' This inconsistency leads to a different display in my project, which utilizes both ngx-bootstrap and moment.js configurations.

As an Indonesian myself, I propose following moment.js locale configuration, as it has become more common lately to abbreviate the month name 'August' as 'Agt.'

Reference to moment.js locale configuration: https://github.com/moment/moment/blob/develop/locale/id.js#L19
Reference to ICU locale for Indonesia (id-ID): https://www.localeplanet.com/icu/id-ID/index.html

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants