feat: 802 combobox by jarred-ritense · Pull Request #852 · valtimo-platform/valtimo

jarred-ritense · 2026-07-27T09:01:11Z

Describe the changes

Link to the related Github issue: generiekzaakafhandelcomponent/gzac-issues#802

Specify the code branch location:

Relevant comments:

Breaking changes

[ x] The contribution only contains changes that are not breaking.

Documentation

Release notes have been written for these changes.

New features or changes that have been introduced have been documented.

[ x] Yes
Not applicable

Tests

Unit tests have been added that cover these changes

Yes
Not applicable

Integration tests have been added that cover these changes

Yes
Not applicable

Describe the testing steps

Step 1
Step 2
Step 3

Security

The Secure by Design principle has been applied to these changes

Yes
Not applicable

Added or changed REST API endpoints have authentication and authorization in place

Yes
Not applicable

Valtimo access control checks have been implemented

Yes
Not applicable

Dependencies

Newly added dependencies do not introduce known vulnerabilities/CVE's and are in line with the Valtimo license

Yes
Not applicable

…anges to the same value.

coderabbitai · 2026-07-27T09:01:20Z

📝 Walkthrough

Summary by CodeRabbit

New Features
- Replaced legacy dropdowns and select fields with searchable combo boxes in process progress and migration workflows.
- Added clearer labels, placeholders, loading states, and selection behavior.
- Improved process migration selections for definitions, versions, and task mappings.
- Selections now stay synchronized when data loads, diagrams update, or migrations complete.
- Improved reliability when switching process definitions or versions during loading.
- Added English and Dutch labels for migration selection fields.

Walkthrough

The case progress process selector now uses a Carbon combo box and extracts process instance identifiers from selected list items. The migration screen replaces native selects with combo boxes for definitions, versions, and task mappings. Migration component state now maintains combo box items, refreshes selections during loading and migration, ignores stale version responses, and caches filtered task mapping options. The migration module imports Carbon’s combo box module, and English and Dutch migration labels are added.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch feature/802-combobox

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b317145c-88da-422f-bdb6-5e73c41c7032

📥 Commits

Reviewing files that changed from the base of the PR and between 675b51b and ac0ddc2.

📒 Files selected for processing (5)

frontend/projects/valtimo/case/src/lib/components/case-detail/tab/progress/progress.component.html
frontend/projects/valtimo/case/src/lib/components/case-detail/tab/progress/progress.component.ts
frontend/projects/valtimo/migration/src/lib/migration.component.html
frontend/projects/valtimo/migration/src/lib/migration.component.ts
frontend/projects/valtimo/migration/src/lib/migration.module.ts

sofiaIvarsRitense · 2026-08-03T10:26:39Z

      });
  }

+  onDefinitionSelected(selection: ListItem | ListItem[], type: string) {


Suggested change

onDefinitionSelected(selection: ListItem | ListItem[], type: string) {

public onDefinitionSelected(selection: ListItem | ListItem[], type: string) {

sofiaIvarsRitense · 2026-08-03T10:26:47Z

+    }
+  }
+
+  onVersionSelected(selection: ListItem | ListItem[], type: string) {


Suggested change

onVersionSelected(selection: ListItem | ListItem[], type: string) {

public onVersionSelected(selection: ListItem | ListItem[], type: string) {

sofiaIvarsRitense · 2026-08-03T10:26:54Z

+    this.loadProcess(item?.id ?? null, type);
+  }
+
+  onTaskMappingSelected(selection: ListItem | ListItem[], nodeId: string) {


Suggested change

onTaskMappingSelected(selection: ListItem | ListItem[], nodeId: string) {

public onTaskMappingSelected(selection: ListItem | ListItem[], nodeId: string) {

sofiaIvarsRitense · 2026-08-03T10:27:02Z

    });
  }

+  getFilteredTargetFlowNodeMapItems(node): ListItem[] {


Suggested change

getFilteredTargetFlowNodeMapItems(node): ListItem[] {

public getFilteredTargetFlowNodeMapItems(node): ListItem[] {

sofiaIvarsRitense · 2026-08-06T07:42:25Z

+        <cds-combo-box
+          [dropUp]="false"
+          [appendInline]="true"
+          [label]="'Source Definition'"


Could you add this to the translations, please?

sofiaIvarsRitense · 2026-08-06T07:42:31Z

+          [dropUp]="false"
+          [appendInline]="true"
+          [label]="'Source Definition'"
+          [placeholder]="'- Source Definition -'"


Also this translation

sofiaIvarsRitense · 2026-08-06T07:42:36Z

+        <cds-combo-box
+          [dropUp]="false"
+          [appendInline]="true"
+          [label]="'Source Version'"


Also this translation

sofiaIvarsRitense · 2026-08-06T07:42:40Z

+          [dropUp]="false"
+          [appendInline]="true"
+          [label]="'Source Version'"
+          [placeholder]="'- Source Version -'"


sofiaIvarsRitense · 2026-08-06T07:42:45Z

+        <cds-combo-box
+          [dropUp]="false"
+          [appendInline]="true"
+          [label]="'Target Definition'"


sofiaIvarsRitense · 2026-08-06T07:42:49Z

+          [dropUp]="false"
+          [appendInline]="true"
+          [label]="'Target Definition'"
+          [placeholder]="'- Target Definition -'"


sofiaIvarsRitense · 2026-08-06T07:42:59Z

+        <cds-combo-box
+          [dropUp]="false"
+          [appendInline]="true"
+          [label]="'Target Version'"


sofiaIvarsRitense · 2026-08-06T07:43:04Z

+          [dropUp]="false"
+          [appendInline]="true"
+          [label]="'Target Version'"
+          [placeholder]="'- Target Version -'"


sofiaIvarsRitense · 2026-08-06T07:43:17Z

+          <cds-combo-box
+            [dropUp]="false"
+            [appendInline]="true"
+            [placeholder]="'- Choose Target -'"


coderabbitai

Actionable comments posted: 1

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 816ee33b-77d7-41d0-a04a-b0fd2ac6ca8e

📥 Commits

Reviewing files that changed from the base of the PR and between d81c01e and b2bac18.

📒 Files selected for processing (5)

frontend/projects/valtimo/case/src/lib/components/case-detail/tab/progress/progress.component.html
frontend/projects/valtimo/case/src/lib/components/case-detail/tab/progress/progress.component.ts
frontend/projects/valtimo/migration/src/lib/migration.component.html
frontend/projects/valtimo/shared/assets/core/en.json
frontend/projects/valtimo/shared/assets/core/nl.json

🚧 Files skipped from review as they are similar to previous changes (3)

frontend/projects/valtimo/case/src/lib/components/case-detail/tab/progress/progress.component.ts
frontend/projects/valtimo/migration/src/lib/migration.component.html
frontend/projects/valtimo/case/src/lib/components/case-detail/tab/progress/progress.component.html

coderabbitai · 2026-08-06T10:55:45Z

+  "Source Definition": "Bron definitie",
+  "Source Version": "Bron versie",
+  "Target Definition": "Doel definitie",
+  "Target Version": "Doel versie",
+  "Choose Target": "Kies doel",


🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Use compound nouns in the Dutch migration labels.

Bron definitie, Bron versie, Doel definitie, and Doel versie are not idiomatic Dutch compound nouns. Use Brondefinitie, Bronversie, Doeldefinitie, and Doelversie.

Proposed fix

- "Source Definition": "Bron definitie", - "Source Version": "Bron versie", - "Target Definition": "Doel definitie", - "Target Version": "Doel versie", + "Source Definition": "Brondefinitie", + "Source Version": "Bronversie", + "Target Definition": "Doeldefinitie", + "Target Version": "Doelversie",

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

"Source Definition": "Bron definitie",

"Source Version": "Bron versie",

"Target Definition": "Doel definitie",

"Target Version": "Doel versie",

"Choose Target": "Kies doel",

"Source Definition": "Brondefinitie",

"Source Version": "Bronversie",

"Target Definition": "Doeldefinitie",

"Target Version": "Doelversie",

"Choose Target": "Kies doel",

jarred-ritense added 3 commits July 23, 2026 20:40

802 Can search entries in migration screen and progress tab.

23baf37

802 If a user changes the source definition, the source definition ch…

d54c2e2

…anges to the same value.

Merge branch 'next-minor' into feature/802-combobox

ac0ddc2

jarred-ritense marked this pull request as ready for review July 28, 2026 08:31

jarred-ritense requested a review from a team as a code owner July 28, 2026 08:31

coderabbitai Bot reviewed Jul 28, 2026

View reviewed changes

Comment thread frontend/projects/valtimo/migration/src/lib/migration.component.ts

elenacherneenkova assigned mbritense Jul 30, 2026

sofiaIvarsRitense self-assigned this Jul 31, 2026

sofiaIvarsRitense reviewed Aug 3, 2026

View reviewed changes

sofiaIvarsRitense added feedback test env Create a remote test environment for this PR in the Ritense product development cluster labels Aug 5, 2026

jarred-ritense added 2 commits August 5, 2026 13:26

802 Feedback pr.

d81c01e

Merge branch 'next-minor' into feature/802-combobox

26a0abb

sofiaIvarsRitense reviewed Aug 6, 2026

View reviewed changes

802 Added translation.

b2bac18

coderabbitai Bot reviewed Aug 6, 2026

View reviewed changes

	onDefinitionSelected(selection: ListItem \| ListItem[], type: string) {
	public onDefinitionSelected(selection: ListItem \| ListItem[], type: string) {

	onVersionSelected(selection: ListItem \| ListItem[], type: string) {
	public onVersionSelected(selection: ListItem \| ListItem[], type: string) {

	onTaskMappingSelected(selection: ListItem \| ListItem[], nodeId: string) {
	public onTaskMappingSelected(selection: ListItem \| ListItem[], nodeId: string) {

	getFilteredTargetFlowNodeMapItems(node): ListItem[] {
	public getFilteredTargetFlowNodeMapItems(node): ListItem[] {

Uh oh!

Conversation

jarred-ritense commented Jul 27, 2026

Describe the changes

Breaking changes

Documentation

Tests

Security

Dependencies

Uh oh!

coderabbitai Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

coderabbitai Bot commented Jul 27, 2026 •

edited

Loading