integration test hostname changed to local IP - #55
Open
bubylou wants to merge 6 commits into
Open
Conversation
Allows for building in environments other than the existing container with the name "app" workflow.
vanadium23
reviewed
Mar 29, 2026
bubylou
force-pushed
the
patch-1
branch
2 times, most recently
from
March 29, 2026 14:02
98079f1 to
6e29234
Compare
Author
|
My original reason for this change was for building this application for NixOS which I recently found out that the default sandbox does not allow networking. I'll have to either skip that particular test or build inside a container. I no longer have a use for this change. @vanadium23 am I good to close this PR or did you want to keep the change? |
vanadium23
reviewed
Apr 6, 2026
| user = readPrefixedEnv("TEST_USER") | ||
| password = readPrefixedEnv("TEST_PASSWORD") | ||
|
|
||
| if user == "" || password == "" { |
Owner
There was a problem hiding this comment.
I think it needs to be something like:
if user == "" {
user = "user"
}
if password == "" {
password = "password"
}
Owner
|
@bubylou can you fix the integration tests? |
Author
Tests pass on my machine now, I should have checked that earlier. Just need your approval to run the workflow and make sure that passes too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows for building in environments other than the existing container with the name "app" workflow. Resolves #54