-
Notifications
You must be signed in to change notification settings - Fork 7
fix(generic-delegator): correct gas estimation for smart-account txs #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
77e2aeb
fix(generic-delegator): correct gas estimation for smart-account txs
Agilulfo1820 773b458
perf(generic-delegator): hoist local gas estimate out of token loop +…
Agilulfo1820 2a9cd70
revert: keep fee-estimation UI hooks unchanged
Agilulfo1820 e3d1ba8
debug(generic-delegator): log enabled-inputs to identify falsy gate
Agilulfo1820 4ded349
fix(provider): always auto-inject generic delegator URL
Agilulfo1820 aa0f527
fix(generic-delegator): use locally-corrected gas in fee-estimation UI
Agilulfo1820 1949da9
feat(cross-app): relabel generic-delegator fee transfers as "Pay tran…
Agilulfo1820 1edaf19
feat(domains/profile): kit pays gas for onboarding actions
Agilulfo1820 3125daa
fix(theme): pin Input/Textarea font-size to 16px to stop iOS auto-zoom
Agilulfo1820 51f192e
fix(gas-fee-selector): coherent hover surface in both color modes
Agilulfo1820 21946bb
fix(gas-fee-selector): tone down selected-row background
Agilulfo1820 3401b5b
Merge branch 'main' into fix/generic-delegator-gas-estimation
Agilulfo1820 5a7b685
fix(choose-name): only sponsor gas for claim, not for unset
Agilulfo1820 a305562
feat(send-token): auto-adjust amount when sending token == gas token
Agilulfo1820 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restrict fee relabeling to supported gas tokens only.
Right now, any ERC‑20
transferto the deposit account is shown as “Pay transaction fee”. That can hide a malicious transfer of an unrelated token. Gate this branch to known fee tokens (e.g., VTHO/B3TR/VOT3 by address) before returningcategory: 'fee'.Suggested guard
📝 Committable suggestion
🤖 Prompt for AI Agents