chore(metrics): introduce enums for metric names#25342
Open
thomasqueirozb wants to merge 18 commits intomasterfrom
Open
chore(metrics): introduce enums for metric names#25342thomasqueirozb wants to merge 18 commits intomasterfrom
thomasqueirozb wants to merge 18 commits intomasterfrom
Conversation
thomasqueirozb
added
the
no-changelog
github-actions
Bot
added
domain: topology
thomasqueirozb
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f769eed08
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
pront
approved these changes
May 1, 2026
Member
pront
left a comment
pront
left a comment
There was a problem hiding this comment.
This is a good improvement lib/vector-common/src/internal_event/metric_name.rs we can also start generating docs from this.
pront
reviewed
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces raw string literals in
counter!,histogram!, andgauge!macro calls with typed enums:CounterName,HistogramName, andGaugeName— defined invector-common. The wrapper macros enforce at compile time that each macro receives the correct enum type, making the full set of internal metric names discoverable and exposable via the API.Vector configuration
NA
How did you test this PR?
make check-clippyandcargo check --workspacepass clean.Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
#21735 (undocumented metrics)