Skip to content

Fixed bug where screen would 'bounce' when presenting in a modal dialog ... #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rrossinvicara wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fixed bug where screen would 'bounce' when presenting in a modal dialog ... #37

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4e34a01
Fixed bug where screen would 'bounce' when presenting in a modal dial…
Nov 17, 2014
94df6ee
Updated code style.
Nov 21, 2014
c2b8e1d
Added support for return key type and a few other minor bugfixes[D
Dec 1, 2014
112d096
Updated podspec for new version
Dec 1, 2014
588c0e0
Updated podspec
Dec 1, 2014
b4dee4b
Fixed bug that duplicated tokens
Dec 1, 2014
dc0df4a
Added back in podspec info
Dec 1, 2014
46dcc33
Removed unnecessary delegate callback
rrossinvicara Dec 1, 2014
3152148
Update VENTokenField.podspec
rrossinvicara Mar 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion VENTokenField/VENTokenField.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,11 @@ - (void)layoutTokensAndInputWithFrameAdjustment:(BOOL)shouldAdjustFrame
{
[self.collapsedLabel removeFromSuperview];
BOOL inputFieldShouldBecomeFirstResponder = self.inputTextField.isFirstResponder;
[self.scrollView.subviews makeObjectsPerformSelector:@selector(removeFromSuperview)];
[self.scrollView.subviews enumerateObjectsUsingBlock:^(id obj, NSUInteger idx, BOOL *stop) {
if (obj == self.inputTextField) return;

@ayanonagon ayanonagon Nov 18, 2014

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the pull-request. Instead of early return, can it be:

if (obj != self.inputTextField) {
    [obj removeFromSuperview];
}

:octocat:


[obj removeFromSuperview];
}];
self.scrollView.hidden = NO;
[self removeGestureRecognizer:self.tapGestureRecognizer];

Expand Down