fix(next-mdx): forward plugin load errors to webpack callback#94119
Open
Jinoko01 wants to merge 1 commit into
Open
fix(next-mdx): forward plugin load errors to webpack callback#94119Jinoko01 wants to merge 1 commit into
Jinoko01 wants to merge 1 commit into
Conversation
timneutkens
requested changes
May 27, 2026
Contributor
timneutkens
left a comment
timneutkens
left a comment
There was a problem hiding this comment.
Can you add a test for the changes. You can use pnpm new-test (or ask an AI agent)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add
.catch()handler to the Promise inmdx-js-loader.jsso thatplugin resolution failures are properly forwarded to webpack's error callback.
Why?
When a plugin string path fails to resolve (e.g. typo in plugin name,
missing package),
getOptions()returns a rejected Promise. Without.catch(), webpack's callback is never called, causing the build tohang indefinitely or throw an unhandled promise rejection instead of
a clear error message.
How?
Chain
.catch((error) => callback(error))after the existing.then()in
nextMdxLoader.Fixes #94118